netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v2] selftests/net: call sendmmsg via udpgso_bench.sh
@ 2024-12-03 22:28 Kenjiro Nakayama
  2024-12-04 14:02 ` Hangbin Liu
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kenjiro Nakayama @ 2024-12-03 22:28 UTC (permalink / raw)
  To: Pablo Neira Ayuso, Jozsef Kadlecsik, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
	Alan Stern, Andrea Parri, Will Deacon, Peter Zijlstra, Boqun Feng,
	Nicholas Piggin, David Howells, Jade Alglave, Luc Maranget,
	Paul E. McKenney, Akira Yokosawa, Daniel Lustig, Joel Fernandes,
	Shuah Khan
  Cc: netfilter-devel, coreteam, linux-kernel, netdev, linux-arch, lkmm,
	linux-kselftest, Kenjiro Nakayama

Currently, sendmmsg is implemented in udpgso_bench_tx.c,
but it is not called by any test script.

This patch adds a test for sendmmsg in udpgso_bench.sh.
This allows for basic API testing and benchmarking
comparisons with GSO.

Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
---
 tools/testing/selftests/net/udpgso_bench.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
index 640bc43452fa..88fa1d53ba2b 100755
--- a/tools/testing/selftests/net/udpgso_bench.sh
+++ b/tools/testing/selftests/net/udpgso_bench.sh
@@ -92,6 +92,9 @@ run_udp() {
 	echo "udp"
 	run_in_netns ${args}
 
+	echo "udp sendmmsg"
+	run_in_netns ${args} -m
+
 	echo "udp gso"
 	run_in_netns ${args} -S 0
 
-- 
2.39.3 (Apple Git-146)


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next v2] selftests/net: call sendmmsg via udpgso_bench.sh
  2024-12-03 22:28 [PATCH net-next v2] selftests/net: call sendmmsg via udpgso_bench.sh Kenjiro Nakayama
@ 2024-12-04 14:02 ` Hangbin Liu
  2024-12-04 19:16 ` Willem de Bruijn
  2024-12-05  3:30 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Hangbin Liu @ 2024-12-04 14:02 UTC (permalink / raw)
  To: Kenjiro Nakayama
  Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Simon Horman,
	Alan Stern, Andrea Parri, Will Deacon, Peter Zijlstra, Boqun Feng,
	Nicholas Piggin, David Howells, Jade Alglave, Luc Maranget,
	Paul E. McKenney, Akira Yokosawa, Daniel Lustig, Joel Fernandes,
	Shuah Khan, netfilter-devel, coreteam, linux-kernel, netdev,
	linux-arch, lkmm, linux-kselftest

On Wed, Dec 04, 2024 at 07:28:44AM +0900, Kenjiro Nakayama wrote:
> Currently, sendmmsg is implemented in udpgso_bench_tx.c,
> but it is not called by any test script.
> 
> This patch adds a test for sendmmsg in udpgso_bench.sh.
> This allows for basic API testing and benchmarking
> comparisons with GSO.
> 
> Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
> ---
>  tools/testing/selftests/net/udpgso_bench.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
> index 640bc43452fa..88fa1d53ba2b 100755
> --- a/tools/testing/selftests/net/udpgso_bench.sh
> +++ b/tools/testing/selftests/net/udpgso_bench.sh
> @@ -92,6 +92,9 @@ run_udp() {
>  	echo "udp"
>  	run_in_netns ${args}
>  
> +	echo "udp sendmmsg"
> +	run_in_netns ${args} -m
> +
>  	echo "udp gso"
>  	run_in_netns ${args} -S 0
>  
> -- 
> 2.39.3 (Apple Git-146)
> 
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next v2] selftests/net: call sendmmsg via udpgso_bench.sh
  2024-12-03 22:28 [PATCH net-next v2] selftests/net: call sendmmsg via udpgso_bench.sh Kenjiro Nakayama
  2024-12-04 14:02 ` Hangbin Liu
@ 2024-12-04 19:16 ` Willem de Bruijn
  2024-12-05  3:30 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Willem de Bruijn @ 2024-12-04 19:16 UTC (permalink / raw)
  To: Kenjiro Nakayama, Pablo Neira Ayuso, Jozsef Kadlecsik,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Simon Horman, Alan Stern, Andrea Parri, Will Deacon,
	Peter Zijlstra, Boqun Feng, Nicholas Piggin, David Howells,
	Jade Alglave, Luc Maranget, Paul E. McKenney, Akira Yokosawa,
	Daniel Lustig, Joel Fernandes, Shuah Khan
  Cc: netfilter-devel, coreteam, linux-kernel, netdev, linux-arch, lkmm,
	linux-kselftest, Kenjiro Nakayama

Kenjiro Nakayama wrote:
> Currently, sendmmsg is implemented in udpgso_bench_tx.c,
> but it is not called by any test script.
> 
> This patch adds a test for sendmmsg in udpgso_bench.sh.
> This allows for basic API testing and benchmarking
> comparisons with GSO.
> 
> Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next v2] selftests/net: call sendmmsg via udpgso_bench.sh
  2024-12-03 22:28 [PATCH net-next v2] selftests/net: call sendmmsg via udpgso_bench.sh Kenjiro Nakayama
  2024-12-04 14:02 ` Hangbin Liu
  2024-12-04 19:16 ` Willem de Bruijn
@ 2024-12-05  3:30 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-12-05  3:30 UTC (permalink / raw)
  To: Kenjiro Nakayama
  Cc: pablo, kadlec, davem, edumazet, kuba, pabeni, horms, stern,
	parri.andrea, will, peterz, boqun.feng, npiggin, dhowells,
	j.alglave, luc.maranget, paulmck, akiyks, dlustig, joel, shuah,
	netfilter-devel, coreteam, linux-kernel, netdev, linux-arch, lkmm,
	linux-kselftest

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  4 Dec 2024 07:28:44 +0900 you wrote:
> Currently, sendmmsg is implemented in udpgso_bench_tx.c,
> but it is not called by any test script.
> 
> This patch adds a test for sendmmsg in udpgso_bench.sh.
> This allows for basic API testing and benchmarking
> comparisons with GSO.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] selftests/net: call sendmmsg via udpgso_bench.sh
    https://git.kernel.org/netdev/net-next/c/ac98b3132402

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-05  3:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-03 22:28 [PATCH net-next v2] selftests/net: call sendmmsg via udpgso_bench.sh Kenjiro Nakayama
2024-12-04 14:02 ` Hangbin Liu
2024-12-04 19:16 ` Willem de Bruijn
2024-12-05  3:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).