From: Stanislav Fomichev <stfomichev@gmail.com>
To: "Song, Yoong Siang" <yoong.siang.song@intel.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next 1/1] selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata
Date: Thu, 5 Dec 2024 11:25:35 -0800 [thread overview]
Message-ID: <Z1H-L3BkxnjVr5Qy@mini-arch> (raw)
In-Reply-To: <PH0PR11MB58309455A6E72493687D0515D8302@PH0PR11MB5830.namprd11.prod.outlook.com>
On 12/05, Song, Yoong Siang wrote:
> On Wednesday, December 4, 2024 11:49 PM, Stanislav Fomichev <stfomichev@gmail.com> wrote:
> >On 12/04, Song Yoong Siang wrote:
> >> Set tx_type to HWTSTAMP_TX_ON to enable hardware timestamping for all
> >> outgoing packets.
> >>
> >> Besides, set XDP_UMEM_TX_METADATA_LEN flag to reserve tx_metadata_len bytes
> >> of per-chunk metadata.
> >
> >XDP_UMEM_TX_METADATA_LEN is missing after d5e726d9143c ("xsk: Require
> >XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"), so that make
> >sense. Maybe add a fixes tag?
> >
>
> Sure. I will add the fixes tag and submit with "PATCH bpf" prefix
> in next version.
>
> >And I don't see mlx5 looking at HWTSTAMP_TX anywhere in the drivers,
> >so I'm assuming that's why I didn't need HWTSTAMP_TX_ON during my tests..
> >Which device are you testing against? I do see some hwts_tx_en
> >checks in the stfmmac at least... Can you add these details to the
> >commit message and respin?
> >
>
> I am testing on stmmac and igc drivers.
> You are right, stmmac needs it for hwts_tx_en check.
> Besides, igc needs it to set IGC_RING_FLAG_TX_HWTSTAMP flag.
>
> Without this patch, user will need to manually enable tx hwts using
> command: sudo hwstamp_ctl -i eth0 -t 1 -r 1
> after start xdp_hw_metadata.
>
> Therefore, adding HWTSTAMP_TX_ON is not a bug fix solution.
> I will separate this as another new patch to "PATCH bpf-next"
> and provide detail in commit message.
>
> Btw, is mlx5 driver always enable Tx HWTS?
I don't remember doing anything special to enable it. And looking at
the code I also don't see any conditionals on HWTSTAMP_TX_ON.
prev parent reply other threads:[~2024-12-05 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 11:57 [PATCH bpf-next 1/1] selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata Song Yoong Siang
2024-12-04 15:48 ` Stanislav Fomichev
2024-12-05 1:36 ` Song, Yoong Siang
2024-12-05 19:25 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1H-L3BkxnjVr5Qy@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).