From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Justin Lai <justinlai0215@realtek.com>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
horms@kernel.org, michal.kubiak@intel.com, pkshih@realtek.com,
larry.chiu@realtek.com
Subject: Re: [PATCH net-next] rtase: Refine the if statement
Date: Fri, 6 Dec 2024 11:44:58 +0100 [thread overview]
Message-ID: <Z1LVqssDBEZ7nsWQ@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20241206084851.760475-1-justinlai0215@realtek.com>
On Fri, Dec 06, 2024 at 04:48:51PM +0800, Justin Lai wrote:
> Refine the if statement to improve readability.
>
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
> ---
> drivers/net/ethernet/realtek/rtase/rtase_main.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
[...]
I am not sure if it is worth to change. However, looks correct:
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> --
> 2.34.1
next prev parent reply other threads:[~2024-12-06 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 8:48 [PATCH net-next] rtase: Refine the if statement Justin Lai
2024-12-06 10:44 ` Michal Swiatkowski [this message]
2024-12-06 16:41 ` Jakub Kicinski
2024-12-09 5:42 ` Michal Swiatkowski
2024-12-08 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1LVqssDBEZ7nsWQ@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justinlai0215@realtek.com \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).