From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 590E246B8 for ; Sun, 8 Dec 2024 03:27:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733628424; cv=none; b=uajjAKiLJ/7aw8YZS0teRgTXYQF8av3IWlR17tHhoPMtofui7Rz2TAKqnB22pIy6IJlWXJD5VXeZpJ1yFUfp7t/PR9Za7vBenI79kofwoutr9bawvHHCYBVraIMiL9WNcvxYxSUOD4lhbpgrW63LSwcfKJGzgxnS9ClXCYTTCyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733628424; c=relaxed/simple; bh=xPxcS+DgpX296WLAauhqmmrHnvlAmFGQynHPtzWY8EY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V5QiMEQWL7sATsA2PKlWEPzDwWclG4r7Wv0lzldSjUpO5mW337N4wsXv3bX4iOXw4XVkOPhLoVJd04DBN71hk3KpoETJJJ9gPsl5lf+3R852+4b898Yo3uXbqk9d6x+In6el7g173qHamO3mIwLF2mSQGLpSf3AKnObFbRJnpO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98) (envelope-from ) id 1tK7YL-000000006ze-18Ds; Sun, 08 Dec 2024 03:01:49 +0000 Date: Sun, 8 Dec 2024 03:01:38 +0000 From: Daniel Golle To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexander Couzens , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 2/3] net: pcs: pcs-mtk-lynxi: implement pcs_inband_caps() method Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 05, 2024 at 09:42:29AM +0000, Russell King (Oracle) wrote: > Report the PCS in-band capabilities to phylink for the LynxI PCS. > > Signed-off-by: Russell King (Oracle) > --- > drivers/net/pcs/pcs-mtk-lynxi.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c > index 4f63abe638c4..7de804535229 100644 > --- a/drivers/net/pcs/pcs-mtk-lynxi.c > +++ b/drivers/net/pcs/pcs-mtk-lynxi.c > @@ -88,6 +88,21 @@ static struct mtk_pcs_lynxi *pcs_to_mtk_pcs_lynxi(struct phylink_pcs *pcs) > return container_of(pcs, struct mtk_pcs_lynxi, pcs); > } > > +static unsigned int mtk_pcs_lynxi_inband_caps(struct phylink_pcs *pcs, > + phy_interface_t interface) > +{ > + switch (interface) { > + case PHY_INTERFACE_MODE_1000BASEX: > + case PHY_INTERFACE_MODE_2500BASEX: > + case PHY_INTERFACE_MODE_SGMII: > + case PHY_INTERFACE_MODE_QSGMII: QSGMII is not supported by this PCS. Apart from that looks good to me. Reviewed-by: Daniel Golle