From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michael Dege <michael.dege@renesas.com>,
Christian Mardmoeller <christian.mardmoeller@renesas.com>,
Dennis Ostermann <dennis.ostermann@renesas.com>
Subject: Re: [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports
Date: Mon, 9 Dec 2024 08:25:12 +0100 [thread overview]
Message-ID: <Z1abWKCVKbaLFfcr@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20241206192140.1714-1-nikita.yoush@cogentembedded.com>
On Sat, Dec 07, 2024 at 12:21:39AM +0500, Nikita Yushchenko wrote:
> In rswitch_ether_port_init_all(), only enabled ports are initialized.
> Then, rswitch_ether_port_deinit_all() shall also only deinitialize
> enabled ports.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
> drivers/net/ethernet/renesas/rswitch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index 3b57abada200..cba80ccc3ce2 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1527,7 +1527,7 @@ static void rswitch_ether_port_deinit_all(struct rswitch_private *priv)
> {
> unsigned int i;
>
> - for (i = 0; i < RSWITCH_NUM_PORTS; i++) {
> + rswitch_for_each_enabled_port(priv, i) {
> phy_exit(priv->rdev[i]->serdes);
> rswitch_ether_port_deinit_one(priv->rdev[i]);
> }
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> --
> 2.39.5
next prev parent reply other threads:[~2024-12-09 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 19:21 [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports Nikita Yushchenko
2024-12-06 19:21 ` [PATCH net-next 2/2] net: renesas: rswitch: remove speed from gwca structure Nikita Yushchenko
2024-12-09 7:24 ` Michal Swiatkowski
2024-12-09 7:25 ` Michal Swiatkowski [this message]
2024-12-10 2:40 ` [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1abWKCVKbaLFfcr@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=christian.mardmoeller@renesas.com \
--cc=davem@davemloft.net \
--cc=dennis.ostermann@renesas.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael.dege@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).