* [PATCH net-next 2/2] net: renesas: rswitch: remove speed from gwca structure
2024-12-06 19:21 [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports Nikita Yushchenko
@ 2024-12-06 19:21 ` Nikita Yushchenko
2024-12-09 7:24 ` Michal Swiatkowski
2024-12-09 7:25 ` [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports Michal Swiatkowski
2024-12-10 2:40 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: Nikita Yushchenko @ 2024-12-06 19:21 UTC (permalink / raw)
To: Yoshihiro Shimoda, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Geert Uytterhoeven
Cc: netdev, linux-renesas-soc, linux-kernel, Michael Dege,
Christian Mardmoeller, Dennis Ostermann, Nikita Yushchenko
This field is set but never used.
GWCA is rswitch CPU interface module which connects rswitch to the
host over AXI bus. Speed of the switch ports is not anyhow related to
GWCA operation.
Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
---
drivers/net/ethernet/renesas/rswitch.c | 3 ---
drivers/net/ethernet/renesas/rswitch.h | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
index cba80ccc3ce2..8ac6ef532c6a 100644
--- a/drivers/net/ethernet/renesas/rswitch.c
+++ b/drivers/net/ethernet/renesas/rswitch.c
@@ -1902,9 +1902,6 @@ static int rswitch_device_alloc(struct rswitch_private *priv, unsigned int index
if (err < 0)
goto out_get_params;
- if (rdev->priv->gwca.speed < rdev->etha->speed)
- rdev->priv->gwca.speed = rdev->etha->speed;
-
err = rswitch_rxdmac_alloc(ndev);
if (err < 0)
goto out_rxdmac;
diff --git a/drivers/net/ethernet/renesas/rswitch.h b/drivers/net/ethernet/renesas/rswitch.h
index 72e3ff596d31..303883369b94 100644
--- a/drivers/net/ethernet/renesas/rswitch.h
+++ b/drivers/net/ethernet/renesas/rswitch.h
@@ -993,7 +993,6 @@ struct rswitch_gwca {
DECLARE_BITMAP(used, RSWITCH_MAX_NUM_QUEUES);
u32 tx_irq_bits[RSWITCH_NUM_IRQ_REGS];
u32 rx_irq_bits[RSWITCH_NUM_IRQ_REGS];
- int speed;
};
#define NUM_QUEUES_PER_NDEV 2
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next 2/2] net: renesas: rswitch: remove speed from gwca structure
2024-12-06 19:21 ` [PATCH net-next 2/2] net: renesas: rswitch: remove speed from gwca structure Nikita Yushchenko
@ 2024-12-09 7:24 ` Michal Swiatkowski
0 siblings, 0 replies; 5+ messages in thread
From: Michal Swiatkowski @ 2024-12-09 7:24 UTC (permalink / raw)
To: Nikita Yushchenko
Cc: Yoshihiro Shimoda, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Geert Uytterhoeven, netdev,
linux-renesas-soc, linux-kernel, Michael Dege,
Christian Mardmoeller, Dennis Ostermann
On Sat, Dec 07, 2024 at 12:21:40AM +0500, Nikita Yushchenko wrote:
> This field is set but never used.
>
> GWCA is rswitch CPU interface module which connects rswitch to the
> host over AXI bus. Speed of the switch ports is not anyhow related to
> GWCA operation.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
> drivers/net/ethernet/renesas/rswitch.c | 3 ---
> drivers/net/ethernet/renesas/rswitch.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index cba80ccc3ce2..8ac6ef532c6a 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1902,9 +1902,6 @@ static int rswitch_device_alloc(struct rswitch_private *priv, unsigned int index
> if (err < 0)
> goto out_get_params;
>
> - if (rdev->priv->gwca.speed < rdev->etha->speed)
> - rdev->priv->gwca.speed = rdev->etha->speed;
> -
> err = rswitch_rxdmac_alloc(ndev);
> if (err < 0)
> goto out_rxdmac;
> diff --git a/drivers/net/ethernet/renesas/rswitch.h b/drivers/net/ethernet/renesas/rswitch.h
> index 72e3ff596d31..303883369b94 100644
> --- a/drivers/net/ethernet/renesas/rswitch.h
> +++ b/drivers/net/ethernet/renesas/rswitch.h
> @@ -993,7 +993,6 @@ struct rswitch_gwca {
> DECLARE_BITMAP(used, RSWITCH_MAX_NUM_QUEUES);
> u32 tx_irq_bits[RSWITCH_NUM_IRQ_REGS];
> u32 rx_irq_bits[RSWITCH_NUM_IRQ_REGS];
> - int speed;
> };
>
Nice cleanup
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> #define NUM_QUEUES_PER_NDEV 2
> --
> 2.39.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports
2024-12-06 19:21 [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports Nikita Yushchenko
2024-12-06 19:21 ` [PATCH net-next 2/2] net: renesas: rswitch: remove speed from gwca structure Nikita Yushchenko
@ 2024-12-09 7:25 ` Michal Swiatkowski
2024-12-10 2:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Michal Swiatkowski @ 2024-12-09 7:25 UTC (permalink / raw)
To: Nikita Yushchenko
Cc: Yoshihiro Shimoda, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Geert Uytterhoeven, netdev,
linux-renesas-soc, linux-kernel, Michael Dege,
Christian Mardmoeller, Dennis Ostermann
On Sat, Dec 07, 2024 at 12:21:39AM +0500, Nikita Yushchenko wrote:
> In rswitch_ether_port_init_all(), only enabled ports are initialized.
> Then, rswitch_ether_port_deinit_all() shall also only deinitialize
> enabled ports.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
> drivers/net/ethernet/renesas/rswitch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index 3b57abada200..cba80ccc3ce2 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1527,7 +1527,7 @@ static void rswitch_ether_port_deinit_all(struct rswitch_private *priv)
> {
> unsigned int i;
>
> - for (i = 0; i < RSWITCH_NUM_PORTS; i++) {
> + rswitch_for_each_enabled_port(priv, i) {
> phy_exit(priv->rdev[i]->serdes);
> rswitch_ether_port_deinit_one(priv->rdev[i]);
> }
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> --
> 2.39.5
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports
2024-12-06 19:21 [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports Nikita Yushchenko
2024-12-06 19:21 ` [PATCH net-next 2/2] net: renesas: rswitch: remove speed from gwca structure Nikita Yushchenko
2024-12-09 7:25 ` [PATCH net-next 1/2] net: renesas: rswitch: do not deinit disabled ports Michal Swiatkowski
@ 2024-12-10 2:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-12-10 2:40 UTC (permalink / raw)
To: Nikita Yushchenko
Cc: yoshihiro.shimoda.uh, andrew, davem, edumazet, kuba, pabeni,
geert+renesas, netdev, linux-renesas-soc, linux-kernel,
michael.dege, christian.mardmoeller, dennis.ostermann
Hello:
This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 7 Dec 2024 00:21:39 +0500 you wrote:
> In rswitch_ether_port_init_all(), only enabled ports are initialized.
> Then, rswitch_ether_port_deinit_all() shall also only deinitialize
> enabled ports.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> ---
> drivers/net/ethernet/renesas/rswitch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next,1/2] net: renesas: rswitch: do not deinit disabled ports
https://git.kernel.org/netdev/net-next/c/070927427d82
- [net-next,2/2] net: renesas: rswitch: remove speed from gwca structure
https://git.kernel.org/netdev/net-next/c/32fd46f5b69e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread