From: Guillaume Nault <gnault@redhat.com>
To: James Chapman <jchapman@katalix.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
tparkin@katalix.com, aleksander.lobakin@intel.com,
ricardo@marliere.net, mail@david-bauer.net
Subject: Re: [PATCH net-next] l2tp: Handle eth stats using NETDEV_PCPU_STAT_DSTATS.
Date: Mon, 9 Dec 2024 13:59:36 +0100 [thread overview]
Message-ID: <Z1bpuGs5Y8kmY5hu@debian> (raw)
In-Reply-To: <20241209114607.2342405-1-jchapman@katalix.com>
On Mon, Dec 09, 2024 at 11:46:07AM +0000, James Chapman wrote:
> l2tp_eth uses the TSTATS infrastructure (dev_sw_netstats_*()) for RX
> and TX packet counters and DEV_STATS_INC for dropped counters.
>
> Consolidate that using the DSTATS infrastructure, which can
> handle both packet counters and packet drops. Statistics that don't
> fit DSTATS are still updated atomically with DEV_STATS_INC().
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Thanks!
next prev parent reply other threads:[~2024-12-09 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 11:46 [PATCH net-next] l2tp: Handle eth stats using NETDEV_PCPU_STAT_DSTATS James Chapman
2024-12-09 12:59 ` Guillaume Nault [this message]
2024-12-11 14:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1bpuGs5Y8kmY5hu@debian \
--to=gnault@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jchapman@katalix.com \
--cc=kuba@kernel.org \
--cc=mail@david-bauer.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo@marliere.net \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).