From: Cong Wang <xiyou.wangcong@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
Cong Wang <cong.wang@bytedance.com>
Subject: Re: [Patch bpf v2 0/4] bpf: a bug fix and test cases for bpf_skb_change_tail()
Date: Mon, 9 Dec 2024 21:36:45 -0800 [thread overview]
Message-ID: <Z1fTbcRiDRPU9IPQ@pop-os.localdomain> (raw)
In-Reply-To: <fac7e933-a1cc-4863-9610-f5429da0d849@iogearbox.net>
On Fri, Dec 06, 2024 at 10:35:28PM +0100, Daniel Borkmann wrote:
> Hi Cong,
>
> On 11/29/24 2:22 AM, Cong Wang wrote:
> > From: Cong Wang <cong.wang@bytedance.com>
> >
> > This patchset fixes a bug in bpf_skb_change_tail() helper and adds test
> > cases for it, as requested by Daniel and John.
> >
> > ---
> > v2: added a test case for TC where offsets are positive
> > fixed a typo in 1/4 patch description
> > reduced buffer size in the sockmap test case
>
> I ran the selftest several times but it's repeatedly failing whereas
> without the series bpf tree CI seems fine. The CI fails on tc tests,
> so potentially patch 4 is causing this.
Ah, thanks for catching it.
Previously, the CI job failed due to flaky tests, which are tests that
inconsistently pass or fail. However, this time the failure indicates
a genuine issue.
>
> Switching over to tcx APIs from libbpf might automatically address
> this given the failures seem to be in 'revision unexpected' which is
> likely due to legacy libbpf tc APIs detaching but not deleting the
> underlying qdisc.
Sure, thanks for the hint. I will update this patchset.
Thanks.
prev parent reply other threads:[~2024-12-10 5:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 1:22 [Patch bpf v2 0/4] bpf: a bug fix and test cases for bpf_skb_change_tail() Cong Wang
2024-11-29 1:22 ` [Patch bpf v2 1/4] bpf: Check negative offsets in __bpf_skb_min_len() Cong Wang
2024-11-29 1:22 ` [Patch bpf v2 2/4] selftests/bpf: Add a BPF selftest for bpf_skb_change_tail() Cong Wang
2024-11-29 1:22 ` [Patch bpf v2 3/4] selftests/bpf: Introduce socket_helpers.h for TC tests Cong Wang
2024-11-29 1:22 ` [Patch bpf v2 4/4] selftests/bpf: Test bpf_skb_change_tail() in TC ingress Cong Wang
2024-12-06 21:35 ` [Patch bpf v2 0/4] bpf: a bug fix and test cases for bpf_skb_change_tail() Daniel Borkmann
2024-12-10 5:36 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1fTbcRiDRPU9IPQ@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox