* [PATCH v2 1/2] net: mana: Fix memory leak in mana_gd_setup_irqs
2024-12-09 17:57 [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs Maxim Levitsky
@ 2024-12-09 17:57 ` Maxim Levitsky
2024-12-10 6:13 ` Michal Swiatkowski
2024-12-10 8:05 ` Kalesh Anakkur Purayil
2024-12-09 17:57 ` [PATCH v2 2/2] net: mana: Fix irq_contexts " Maxim Levitsky
` (4 subsequent siblings)
5 siblings, 2 replies; 12+ messages in thread
From: Maxim Levitsky @ 2024-12-09 17:57 UTC (permalink / raw)
To: kvm
Cc: Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov, Maxim Levitsky
Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
doesn't free this temporary array in the success path.
This was caught by kmemleak.
Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
drivers/net/ethernet/microsoft/mana/gdma_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c
index e97af7ac2bb2..aba188f9f10f 100644
--- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
+++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
@@ -1375,6 +1375,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
gc->max_num_msix = nvec;
gc->num_msix_usable = nvec;
cpus_read_unlock();
+ kfree(irqs);
return 0;
free_irq:
--
2.26.3
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2 1/2] net: mana: Fix memory leak in mana_gd_setup_irqs
2024-12-09 17:57 ` [PATCH v2 1/2] net: mana: Fix memory leak " Maxim Levitsky
@ 2024-12-10 6:13 ` Michal Swiatkowski
2024-12-10 6:17 ` Michal Swiatkowski
2024-12-10 8:05 ` Kalesh Anakkur Purayil
1 sibling, 1 reply; 12+ messages in thread
From: Michal Swiatkowski @ 2024-12-10 6:13 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov
On Mon, Dec 09, 2024 at 12:57:50PM -0500, Maxim Levitsky wrote:
> Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
> doesn't free this temporary array in the success path.
>
> This was caught by kmemleak.
>
> Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> drivers/net/ethernet/microsoft/mana/gdma_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> index e97af7ac2bb2..aba188f9f10f 100644
> --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> @@ -1375,6 +1375,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
> gc->max_num_msix = nvec;
> gc->num_msix_usable = nvec;
> cpus_read_unlock();
> + kfree(irqs);
Ther is still memleak in case of jumping to free_irq_vector when
gc->irq_contexts allocation is failing.
Thanks
> return 0;
>
> free_irq:
> --
> 2.26.3
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 1/2] net: mana: Fix memory leak in mana_gd_setup_irqs
2024-12-10 6:13 ` Michal Swiatkowski
@ 2024-12-10 6:17 ` Michal Swiatkowski
0 siblings, 0 replies; 12+ messages in thread
From: Michal Swiatkowski @ 2024-12-10 6:17 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov
On Tue, Dec 10, 2024 at 07:13:53AM +0100, Michal Swiatkowski wrote:
> On Mon, Dec 09, 2024 at 12:57:50PM -0500, Maxim Levitsky wrote:
> > Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> > added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
> > doesn't free this temporary array in the success path.
> >
> > This was caught by kmemleak.
> >
> > Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> > Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> > ---
> > drivers/net/ethernet/microsoft/mana/gdma_main.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> > index e97af7ac2bb2..aba188f9f10f 100644
> > --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> > +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> > @@ -1375,6 +1375,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
> > gc->max_num_msix = nvec;
> > gc->num_msix_usable = nvec;
> > cpus_read_unlock();
> > + kfree(irqs);
>
> Ther is still memleak in case of jumping to free_irq_vector when
> gc->irq_contexts allocation is failing.
>
Ignore that, just took a look at second patch.
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> Thanks
> > return 0;
> >
> > free_irq:
> > --
> > 2.26.3
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 1/2] net: mana: Fix memory leak in mana_gd_setup_irqs
2024-12-09 17:57 ` [PATCH v2 1/2] net: mana: Fix memory leak " Maxim Levitsky
2024-12-10 6:13 ` Michal Swiatkowski
@ 2024-12-10 8:05 ` Kalesh Anakkur Purayil
1 sibling, 0 replies; 12+ messages in thread
From: Kalesh Anakkur Purayil @ 2024-12-10 8:05 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Mon, Dec 9, 2024 at 11:28 PM Maxim Levitsky <mlevitsk@redhat.com> wrote:
>
> Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
> doesn't free this temporary array in the success path.
>
> This was caught by kmemleak.
>
> Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
--
Regards,
Kalesh A P
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 2/2] net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
2024-12-09 17:57 [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs Maxim Levitsky
2024-12-09 17:57 ` [PATCH v2 1/2] net: mana: Fix memory leak " Maxim Levitsky
@ 2024-12-09 17:57 ` Maxim Levitsky
2024-12-10 6:19 ` Michal Swiatkowski
2024-12-10 8:07 ` Kalesh Anakkur Purayil
2024-12-10 6:23 ` [PATCH v2 0/2] MANA: Fix few memory leaks " Michal Swiatkowski
` (3 subsequent siblings)
5 siblings, 2 replies; 12+ messages in thread
From: Maxim Levitsky @ 2024-12-09 17:57 UTC (permalink / raw)
To: kvm
Cc: Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov, Maxim Levitsky, Michael Kelley
gc->irq_contexts is not freeded if one of the later operations
fail.
Suggested-by: Michael Kelley <mhklinux@outlook.com>
Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
drivers/net/ethernet/microsoft/mana/gdma_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c
index aba188f9f10f..6297c0869cd6 100644
--- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
+++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
@@ -1318,7 +1318,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
GFP_KERNEL);
if (!gc->irq_contexts) {
err = -ENOMEM;
- goto free_irq_vector;
+ goto free_irq_array;
}
for (i = 0; i < nvec; i++) {
@@ -1388,8 +1388,9 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
}
kfree(gc->irq_contexts);
- kfree(irqs);
gc->irq_contexts = NULL;
+free_irq_array:
+ kfree(irqs);
free_irq_vector:
cpus_read_unlock();
pci_free_irq_vectors(pdev);
--
2.26.3
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v2 2/2] net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
2024-12-09 17:57 ` [PATCH v2 2/2] net: mana: Fix irq_contexts " Maxim Levitsky
@ 2024-12-10 6:19 ` Michal Swiatkowski
2024-12-10 8:07 ` Kalesh Anakkur Purayil
1 sibling, 0 replies; 12+ messages in thread
From: Michal Swiatkowski @ 2024-12-10 6:19 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov, Michael Kelley
On Mon, Dec 09, 2024 at 12:57:51PM -0500, Maxim Levitsky wrote:
> gc->irq_contexts is not freeded if one of the later operations
> fail.
>
> Suggested-by: Michael Kelley <mhklinux@outlook.com>
> Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> drivers/net/ethernet/microsoft/mana/gdma_main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> index aba188f9f10f..6297c0869cd6 100644
> --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c
> +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c
> @@ -1318,7 +1318,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
> GFP_KERNEL);
> if (!gc->irq_contexts) {
> err = -ENOMEM;
> - goto free_irq_vector;
> + goto free_irq_array;
> }
>
> for (i = 0; i < nvec; i++) {
> @@ -1388,8 +1388,9 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev)
> }
>
> kfree(gc->irq_contexts);
> - kfree(irqs);
> gc->irq_contexts = NULL;
> +free_irq_array:
> + kfree(irqs);
> free_irq_vector:
> cpus_read_unlock();
> pci_free_irq_vectors(pdev);
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> --
> 2.26.3
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 2/2] net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
2024-12-09 17:57 ` [PATCH v2 2/2] net: mana: Fix irq_contexts " Maxim Levitsky
2024-12-10 6:19 ` Michal Swiatkowski
@ 2024-12-10 8:07 ` Kalesh Anakkur Purayil
1 sibling, 0 replies; 12+ messages in thread
From: Kalesh Anakkur Purayil @ 2024-12-10 8:07 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov, Michael Kelley
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On Mon, Dec 9, 2024 at 11:29 PM Maxim Levitsky <mlevitsk@redhat.com> wrote:
>
> gc->irq_contexts is not freeded if one of the later operations
> fail.
>
> Suggested-by: Michael Kelley <mhklinux@outlook.com>
> Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
--
Regards,
Kalesh A P
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs
2024-12-09 17:57 [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs Maxim Levitsky
2024-12-09 17:57 ` [PATCH v2 1/2] net: mana: Fix memory leak " Maxim Levitsky
2024-12-09 17:57 ` [PATCH v2 2/2] net: mana: Fix irq_contexts " Maxim Levitsky
@ 2024-12-10 6:23 ` Michal Swiatkowski
2024-12-10 10:24 ` Saurabh Singh Sengar
` (2 subsequent siblings)
5 siblings, 0 replies; 12+ messages in thread
From: Michal Swiatkowski @ 2024-12-10 6:23 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov
On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
>
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
>
> Best regards,
> Maxim Levitsky
>
For next time please add a changleog, like here for example [1].
It is helpfull for the reviewers.
[1] https://lore.kernel.org/netdev/20241204140821.1858263-1-saikrishnag@marvell.com/T/#m5fc2fa8b1d2bd1b47cf7ccacd4031d1aa1aa8c2c
Thanks
> Maxim Levitsky (2):
> net: mana: Fix memory leak in mana_gd_setup_irqs
> net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
>
> drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> --
> 2.26.3
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs
2024-12-09 17:57 [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs Maxim Levitsky
` (2 preceding siblings ...)
2024-12-10 6:23 ` [PATCH v2 0/2] MANA: Fix few memory leaks " Michal Swiatkowski
@ 2024-12-10 10:24 ` Saurabh Singh Sengar
2024-12-11 18:34 ` Yury Norov
2024-12-12 4:30 ` patchwork-bot+netdevbpf
5 siblings, 0 replies; 12+ messages in thread
From: Saurabh Singh Sengar @ 2024-12-10 10:24 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li, Yury Norov
On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
>
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
>
> Best regards,
> Maxim Levitsky
>
> Maxim Levitsky (2):
> net: mana: Fix memory leak in mana_gd_setup_irqs
> net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
>
> drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> --
> 2.26.3
>
>
Thanks for fixing this, for the series
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
could have been a single patch, though
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs
2024-12-09 17:57 [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs Maxim Levitsky
` (3 preceding siblings ...)
2024-12-10 10:24 ` Saurabh Singh Sengar
@ 2024-12-11 18:34 ` Yury Norov
2024-12-12 4:30 ` patchwork-bot+netdevbpf
5 siblings, 0 replies; 12+ messages in thread
From: Yury Norov @ 2024-12-11 18:34 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, Jakub Kicinski, Haiyang Zhang, Souradeep Chakrabarti,
linux-hyperv, Dexuan Cui, Paolo Abeni, linux-kernel,
Konstantin Taranov, Leon Romanovsky, K. Y. Srinivasan, Wei Liu,
Andrew Lunn, Shradha Gupta, David S. Miller, netdev, Eric Dumazet,
Long Li
On Mon, Dec 09, 2024 at 12:57:49PM -0500, Maxim Levitsky wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
>
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
Reviewed-by: Yury Norov <yury.norov@gmail.com>
>
> Best regards,
> Maxim Levitsky
>
> Maxim Levitsky (2):
> net: mana: Fix memory leak in mana_gd_setup_irqs
> net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
>
> drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs
2024-12-09 17:57 [PATCH v2 0/2] MANA: Fix few memory leaks in mana_gd_setup_irqs Maxim Levitsky
` (4 preceding siblings ...)
2024-12-11 18:34 ` Yury Norov
@ 2024-12-12 4:30 ` patchwork-bot+netdevbpf
5 siblings, 0 replies; 12+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-12-12 4:30 UTC (permalink / raw)
To: Maxim Levitsky
Cc: kvm, kuba, haiyangz, schakrabarti, linux-hyperv, decui, pabeni,
linux-kernel, kotaranov, leon, kys, wei.liu, andrew+netdev,
shradhagupta, davem, netdev, edumazet, longli, yury.norov
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 9 Dec 2024 12:57:49 -0500 you wrote:
> Fix 2 minor memory leaks in the mana driver,
> introduced by commit
>
> 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
>
> Best regards,
> Maxim Levitsky
>
> [...]
Here is the summary with links:
- [v2,1/2] net: mana: Fix memory leak in mana_gd_setup_irqs
https://git.kernel.org/netdev/net/c/bb1e3eb57d2c
- [v2,2/2] net: mana: Fix irq_contexts memory leak in mana_gd_setup_irqs
https://git.kernel.org/netdev/net/c/9a5beb6ca630
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 12+ messages in thread