From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
UNGLinuxDriver@microchip.com, Vladimir Oltean <olteanv@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>
Subject: [PATCH RFC net-next 0/7] net: dsa: cleanup EEE (part 2)
Date: Tue, 10 Dec 2024 14:25:44 +0000 [thread overview]
Message-ID: <Z1hPaLFlR4TW_YCr@shell.armlinux.org.uk> (raw)
This is part 2 of the DSA EEE cleanups, and is being sent out becaues it
is relevant for the review of part 1, but would make part 1 too large.
Patch 1 removes the useless setting of tx_lpi parameters in the
ksz driver.
Patch 2 removes the DSA core code that calls the get_mac_eee() operation.
This needs to be done before removing the implementations because doing
otherwise would cause dsa_user_get_eee() to return -EOPNOTSUPP.
Patches 3..6 remove the trivial get_mac_eee() implementations from DSA
drivers.
Patch 7 finally removes the get_mac_eee() method from struct
dsa_switch_ops.
For part 2:
drivers/net/dsa/b53/b53_common.c | 7 -------
drivers/net/dsa/b53/b53_priv.h | 1 -
drivers/net/dsa/bcm_sf2.c | 1 -
drivers/net/dsa/microchip/ksz_common.c | 15 ---------------
drivers/net/dsa/mv88e6xxx/chip.c | 8 --------
drivers/net/dsa/qca/qca8k-8xxx.c | 1 -
drivers/net/dsa/qca/qca8k-common.c | 7 -------
drivers/net/dsa/qca/qca8k.h | 1 -
include/net/dsa.h | 2 --
net/dsa/user.c | 12 ------------
10 files changed, 55 deletions(-)
For part 1 and part 2 combined results in a net reduction of 33 LOC:
drivers/net/dsa/b53/b53_common.c | 14 ++++----------
drivers/net/dsa/b53/b53_priv.h | 2 +-
drivers/net/dsa/bcm_sf2.c | 2 +-
drivers/net/dsa/microchip/ksz_common.c | 35 +++++-----------------------------
drivers/net/dsa/mt7530.c | 1 +
drivers/net/dsa/mv88e6xxx/chip.c | 9 +--------
drivers/net/dsa/qca/qca8k-8xxx.c | 2 +-
drivers/net/dsa/qca/qca8k-common.c | 7 -------
drivers/net/dsa/qca/qca8k.h | 1 -
include/net/dsa.h | 4 ++--
net/dsa/port.c | 16 ++++++++++++++++
net/dsa/user.c | 18 +++++++----------
12 files changed, 39 insertions(+), 72 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2024-12-10 14:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 14:25 Russell King (Oracle) [this message]
2024-12-10 14:26 ` [PATCH RFC net-next 1/7] net: dsa: ksz: remove setting of tx_lpi parameters Russell King (Oracle)
2024-12-12 19:38 ` Vladimir Oltean
2024-12-10 14:26 ` [PATCH RFC net-next 2/7] net: dsa: no longer call ds->ops->get_mac_eee() Russell King (Oracle)
2024-12-12 19:44 ` Vladimir Oltean
2025-01-02 17:56 ` Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 3/7] net: dsa: b53/bcm_sf2: remove b53_get_mac_eee() Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 4/7] net: dsa: ksz: remove ksz_get_mac_eee() Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 5/7] net: dsa: mv88e6xxx: remove mv88e6xxx_get_mac_eee() Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 6/7] net: dsa: qca: remove qca8k_get_mac_eee() Russell King (Oracle)
2024-12-10 14:26 ` [PATCH RFC net-next 7/7] net: dsa: remove get_mac_eee() method Russell King (Oracle)
2024-12-12 19:48 ` [PATCH RFC net-next 0/7] net: dsa: cleanup EEE (part 2) Vladimir Oltean
2025-01-02 18:18 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1hPaLFlR4TW_YCr@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).