From: Joe Damato <jdamato@fastly.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: donald.hunter@gmail.com, kuba@kernel.org, stfomichev@gmail.com,
pabeni@redhat.com, davem@davemloft.net, edumazet@google.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] tools: ynl: add main install target
Date: Tue, 10 Dec 2024 08:34:03 -0800 [thread overview]
Message-ID: <Z1hte2LnnPdC6DMm@LQ3V64L9R2> (raw)
In-Reply-To: <CAASaF6wVb=c2mYJDqSdjbGD2hQ9CdbxmEKopVoT3Aniy+xRJ+g@mail.gmail.com>
On Tue, Dec 10, 2024 at 02:56:05PM +0100, Jan Stancek wrote:
> On Mon, Dec 9, 2024 at 10:30 PM Joe Damato <jdamato@fastly.com> wrote:
> >
> > On Mon, Dec 09, 2024 at 03:47:17PM +0100, Jan Stancek wrote:
> > > This will install C library, specs, rsts and pyynl. The initial
> > > structure is:
> > >
> > > $ mkdir /tmp/myroot
> > > $ make DESTDIR=/tmp/myroot install
> > >
> > > /usr
> > > /usr/lib64
> > > /usr/lib64/libynl.a
> >
> > This is super useful thanks for doing this work. I could be missing
> > something, but it looks like the install target does not install the
> > generated C headers that user code can include at build time.
> >
> > Am I reading that right? Is that intentional? I was thinking that it
> > would be really useful to have the headers installed, too.
>
> It's not intentional, just noone asked for it yet. We can add those.
> Would /usr/include/ynl/ work? Or do you/others have a different suggestion?
/usr/include/ynl sounds good to me, but happy to see if other folks
have suggestions.
Thanks for being open to adding this; it'll make developing user
apps with libynl much easier.
prev parent reply other threads:[~2024-12-10 16:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 14:47 [PATCH v2 0/5] tools: ynl: add install target Jan Stancek
2024-12-09 14:47 ` [PATCH v2 1/5] tools: ynl: move python code to separate sub-directory Jan Stancek
2024-12-09 14:47 ` [PATCH v2 2/5] tools: ynl: provide symlinks to user-facing scripts for compatibility Jan Stancek
2024-12-11 3:26 ` Jakub Kicinski
2024-12-11 9:21 ` Donald Hunter
2024-12-11 12:42 ` Jan Stancek
2024-12-12 2:13 ` Jakub Kicinski
2024-12-09 14:47 ` [PATCH v2 3/5] tools: ynl: add initial pyproject.toml for packaging Jan Stancek
2024-12-09 14:47 ` [PATCH v2 4/5] tools: ynl: add install target for specs and docs Jan Stancek
2024-12-11 3:31 ` Jakub Kicinski
2024-12-09 14:47 ` [PATCH v2 5/5] tools: ynl: add main install target Jan Stancek
2024-12-09 21:30 ` Joe Damato
2024-12-10 13:56 ` Jan Stancek
2024-12-10 16:34 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1hte2LnnPdC6DMm@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jstancek@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).