From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jose Abreu <joabreu@synopsys.com>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 2/7] net: stmmac: move tx_lpi_timer tracking to phylib
Date: Fri, 13 Dec 2024 10:59:54 +0000 [thread overview]
Message-ID: <Z1wTqh-BnvPYLqU8@shell.armlinux.org.uk> (raw)
In-Reply-To: <E1tLkSX-006qfS-Rx@rmk-PC.armlinux.org.uk>
On Thu, Dec 12, 2024 at 02:46:33PM +0000, Russell King (Oracle) wrote:
> @@ -1092,6 +1092,7 @@ static void stmmac_mac_link_up(struct phylink_config *config,
> phy_init_eee(phy, !(priv->plat->flags &
> STMMAC_FLAG_RX_CLK_RUNS_IN_LPI)) >= 0;
> priv->eee_enabled = stmmac_eee_init(priv);
> + priv->tx_lpi_timer = phy->eee_cfg.tx_lpi_timer;
> priv->tx_lpi_enabled = priv->eee_enabled;
> stmmac_set_eee_pls(priv, priv->hw, true);
> }
While looking deeper at stmmac, there's a bug in the above hunk -
stmmac_eee_init() makes use of priv->tx_lpi_timer, so this member
needs to be set before calling this function. I'll post a v2 shortly.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-12-13 11:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 14:46 [PATCH net-next 0/7] net: stmmac: clean up and fix EEE implementation Russell King (Oracle)
2024-12-12 14:46 ` [PATCH net-next 1/7] net: phy: add configuration of rx clock stop mode Russell King (Oracle)
2024-12-12 14:46 ` [PATCH net-next 2/7] net: stmmac: move tx_lpi_timer tracking to phylib Russell King (Oracle)
2024-12-13 10:59 ` Russell King (Oracle) [this message]
2024-12-13 20:06 ` Russell King (Oracle)
2025-01-02 22:02 ` Russell King (Oracle)
2025-01-06 12:05 ` Russell King (Oracle)
2024-12-12 14:46 ` [PATCH net-next 3/7] net: stmmac: make EEE depend on phy->enable_tx_lpi Russell King (Oracle)
2024-12-12 14:46 ` [PATCH net-next 4/7] net: stmmac: remove redundant code from ethtool EEE ops Russell King (Oracle)
2024-12-12 14:46 ` [PATCH net-next 5/7] net: stmmac: remove priv->tx_lpi_enabled Russell King (Oracle)
2024-12-12 14:46 ` [PATCH net-next 6/7] net: stmmac: report EEE error statistics if EEE is supported Russell King (Oracle)
2024-12-12 14:46 ` [PATCH net-next 7/7] net: stmmac: convert to use phy_eee_rx_clock_stop() Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1wTqh-BnvPYLqU8@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).