From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net 0/5] netdev: fix repeated netlink messages in queue dumps
Date: Fri, 13 Dec 2024 13:52:11 -0800 [thread overview]
Message-ID: <Z1ysi1RHOr3S-40F@LQ3V64L9R2> (raw)
In-Reply-To: <20241213152244.3080955-1-kuba@kernel.org>
On Fri, Dec 13, 2024 at 07:22:39AM -0800, Jakub Kicinski wrote:
> Fix dump continuation for queues and queue stats in the netdev family.
> Because we used post-increment when saving id of dumped queue next
> skb would re-dump the already dumped queue.
>
> Jakub Kicinski (5):
> netdev: fix repeated netlink messages in queue dump
> netdev: fix repeated netlink messages in queue stats
> selftests: net: support setting recv_size in YNL
> selftests: net-drv: queues: sanity check netlink dumps
> selftests: net-drv: stats: sanity check netlink dumps
Thanks for the work and improvements.
Patch 1 and 2 definitely seem to be "fixes" and are against net
which seems appropriate to me.
Patches 3, 4, and 5 seem like new features, though. Should those
three be a separate series against net-next, instead?
In the event that you do decide to separate out 3, 4, and 5 you can
feel free to carry along my Reviewed-bys.
next prev parent reply other threads:[~2024-12-13 21:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 15:22 [PATCH net 0/5] netdev: fix repeated netlink messages in queue dumps Jakub Kicinski
2024-12-13 15:22 ` [PATCH net 1/5] netdev: fix repeated netlink messages in queue dump Jakub Kicinski
2024-12-13 21:41 ` Joe Damato
2024-12-13 15:22 ` [PATCH net 2/5] netdev: fix repeated netlink messages in queue stats Jakub Kicinski
2024-12-13 21:42 ` Joe Damato
2024-12-13 15:22 ` [PATCH net 3/5] selftests: net: support setting recv_size in YNL Jakub Kicinski
2024-12-13 21:45 ` Joe Damato
2024-12-16 10:37 ` Petr Machata
2024-12-13 15:22 ` [PATCH net 4/5] selftests: net-drv: queues: sanity check netlink dumps Jakub Kicinski
2024-12-13 21:47 ` Joe Damato
2024-12-16 10:46 ` Petr Machata
2024-12-13 15:22 ` [PATCH net 5/5] selftests: net-drv: stats: " Jakub Kicinski
2024-12-16 10:53 ` Petr Machata
2024-12-17 1:29 ` Jakub Kicinski
2024-12-13 21:52 ` Joe Damato [this message]
2024-12-14 1:38 ` [PATCH net 0/5] netdev: fix repeated netlink messages in queue dumps Jakub Kicinski
2024-12-17 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1ysi1RHOr3S-40F@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox