Re: [PATCH v9 1/1] mctp pcc: Implement MCTP over PCC Transport

Jeremy Kerr
2024-12-18T00:09:24Z

Hi Joe,

> I suspect what Jeremy meant (but please feel free to correct me if
> I'm mistaken, Jeremy) was that you may want to use the helpers in:
>
> include/linux/netdevice.h

No, I was just referring to the new(-ish) dstats infrastructure in the
core, with dstats collection in rtnl_link_stats64() as of 94b601bc.

However, your suggestion of:

>   dev_dstats_rx_add(mctp_pcc_ndev->mdev.dev, data_len);
>   dev_dstats_rx_dropped(mctp_pcc_ndev->mdev.dev);

make it even simpler! I would agree with the recommendation there.

Cheers,

Jeremy