From: Richard Cochran <richardcochran@gmail.com>
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Dragos Tatulea <dtatulea@nvidia.com>,
Gal Pressman <gal@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>,
Bar Shapira <bshapira@nvidia.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH net-next] net/mlx5: use do_aux_work for PHC overflow checks
Date: Tue, 17 Dec 2024 19:52:17 -0800 [thread overview]
Message-ID: <Z2JG8RGcsQXxP-mS@hoboy.vegasvil.org> (raw)
In-Reply-To: <20241217195738.743391-1-vadfed@meta.com>
On Tue, Dec 17, 2024 at 11:57:38AM -0800, Vadim Fedorenko wrote:
> The overflow_work is using system wq to do overflow checks and updates
> for PHC device timecounter, which might be overhelmed by other tasks.
> But there is dedicated kthread in PTP subsystem designed for such
> things. This patch changes the work queue to proper align with PTP
> subsystem and to avoid overloading system work queue.
Yes, and you can configure that thread with chrt to ensure timely
invocation of the callback.
> @@ -1188,7 +1192,6 @@ void mlx5_cleanup_clock(struct mlx5_core_dev *mdev)
> }
>
> cancel_work_sync(&clock->pps_info.out_work);
> - cancel_delayed_work_sync(&clock->timer.overflow_work);
Do you need ptp_cancel_worker_sync() ?
Thanks,
Richard
next prev parent reply other threads:[~2024-12-18 3:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 19:57 [PATCH net-next] net/mlx5: use do_aux_work for PHC overflow checks Vadim Fedorenko
2024-12-18 3:52 ` Richard Cochran [this message]
2024-12-18 10:19 ` Vadim Fedorenko
2024-12-22 14:10 ` Dragos Tatulea
2025-01-03 22:25 ` Vadim Fedorenko
2025-01-06 14:45 ` Tariq Toukan
2025-01-07 6:21 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2JG8RGcsQXxP-mS@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bshapira@nvidia.com \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vadfed@meta.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).