From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Shahar Shitrit <shshitrit@nvidia.com>,
"brianvv@google.com" <brianvv@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"kuniyu@amazon.com" <kuniyu@amazon.com>,
"martin.lau@kernel.org" <martin.lau@kernel.org>,
"ncardwell@google.com" <ncardwell@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Ziyad Atiyyeh <ziyadat@nvidia.com>,
"Dror Tennenbaum" <drort@nvidia.com>
Subject: Re: [PATCH v3 net-next 4/5] ipv6: tcp: give socket pointer to control skbs
Date: Wed, 18 Dec 2024 09:26:24 +0100 [thread overview]
Message-ID: <Z2KHMLJ4oTUwgBSo@gauss3.secunet.de> (raw)
In-Reply-To: <CANn89iKAZsG=RepuJmStFTH2QK+N5s9Cu=OnD2GmQAb1JKCfeQ@mail.gmail.com>
On Mon, Dec 16, 2024 at 04:21:32PM +0100, Eric Dumazet wrote:
> On Mon, Dec 16, 2024 at 2:29 PM Eric Dumazet <edumazet@google.com> wrote:
> >
> > On Mon, Dec 16, 2024 at 2:18 PM Shahar Shitrit <shshitrit@nvidia.com> wrote:
> > >
> > > Hello,
> > >
> > >
> > >
> > > We observe memory leaks reported by kmemleak when using IPSec in transport mode with crypto offload.
> > >
> > > The leaks reproduce for TX offload, RX offload and both.
> > >
> > > The leaks as shown in stack trace can be seen below.
> > >
> > >
> > >
> > > The issue has been bisected to this commit 507a96737d99686ca1714c7ba1f60ac323178189.
> > >
> > >
> >
> > Nothing comes to mind. This might be an old bug in loopback paths.
>
> Or some XFRM assumption.
>
> Note that ip6_xmit() first parameter can be different than skb->sk
>
> Apparently, xfrm does not check this possibility.
Can you provide a bit more context? I don't see the problem.
Thanks!
next prev parent reply other threads:[~2024-12-18 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CY5PR12MB63224DE8AEEC1A2410E65466DA3B2@CY5PR12MB6322.namprd12.prod.outlook.com>
2024-12-16 13:29 ` [PATCH v3 net-next 4/5] ipv6: tcp: give socket pointer to control skbs Eric Dumazet
2024-12-16 15:21 ` Eric Dumazet
2024-12-18 8:26 ` Steffen Klassert [this message]
2024-12-18 9:04 ` Eric Dumazet
2025-01-06 10:41 ` Steffen Klassert
2024-10-10 17:48 [PATCH v3 net-next 0/5] tcp: add skb->sk to more control packets Eric Dumazet
2024-10-10 17:48 ` [PATCH v3 net-next 4/5] ipv6: tcp: give socket pointer to control skbs Eric Dumazet
2024-10-11 23:32 ` Kuniyuki Iwashima
2024-10-14 14:22 ` Brian Vazquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2KHMLJ4oTUwgBSo@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=brianvv@google.com \
--cc=davem@davemloft.net \
--cc=drort@nvidia.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=martin.lau@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shshitrit@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ziyadat@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).