From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77EDECA5A; Sat, 21 Dec 2024 09:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.6.53.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734772039; cv=none; b=bgaLljQcfTp2TqZVQdmNP1V3Gibry8yordy8i/bRb7iTGq2wVKEM+dmaitI5JW2evs0FCrHX/34zz/MyzpRM15uHVCqqcJLIeFCG3U0t6mRhvAEq1fPYbR3MYV2Cvm5fUvBKS0nBQEymNEblzsuAfbOr7lQmX+ioOeQoJeDKIMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734772039; c=relaxed/simple; bh=WYH0na+ESOSGPKUfQK2wiYT9UF3AAcwfwCpYokRJ6tA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X1Gn0kPt0KxJpbjsmDePSCP4SxJiTXfGnEbrQznc2qX2M3Pn0NM/cBDHQW+vohOnERflSNNQLjsv/oYBBPuBOCFXFlf+hyI5MuCdqR2csQnJgkSHi0gINJMb6/okkExtP/9iCpsdPKIn1Wlgg2D7h8yUVlu7mfxmTcwYxf9bfW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; dkim=pass (2048-bit key) header.d=hmeau.com header.i=@hmeau.com header.b=FCtGZvS9; arc=none smtp.client-ip=144.6.53.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hmeau.com header.i=@hmeau.com header.b="FCtGZvS9" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SzB6uK94xo5/T0BXO1kM/kvir9oQYumj4tut2grbd/g=; b=FCtGZvS95oZ9iiPLt7x2QryztN qviPrHzbNRkP16c1SkkmKT7rW0JzmbZNniA+HmGI7nMzYwpMoAD79Rj7IvU1gQmW1HmAx2VIGsWrS 0hKtrLYy6TlTmLnmIjif9FIZDmYJfx4j6MCi6K6hgZOBnMIclt0GmS80eAsnndapcgZKzxio8ChRs 2ViMoV/XCcc0e7oWS91ET0M9Aus8uGND+MIhFVey28/HNlGenpbXGSZYGYiXt6V5stdrBvV/ISl6t 3i2EihT+zwtVCzw3SGP2ioV4T7FAQwRH7fDt40LCOGEehC0h5IwYUFaDh2yzyqOdXPXHosDCoKSBR AMujarEg==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1tOvEs-002Q20-2S; Sat, 21 Dec 2024 17:06:56 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 21 Dec 2024 17:06:55 +0800 Date: Sat, 21 Dec 2024 17:06:55 +0800 From: Herbert Xu To: Breno Leitao Cc: Andrew Morton , Thomas Graf , Tejun Heo , Hao Luo , Josh Don , Barret Rhoden , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rhashtable: Fix potential deadlock by moving schedule_work outside lock Message-ID: References: <20241128-scx_lockdep-v1-1-2315b813b36b@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Dec 12, 2024 at 08:33:31PM +0800, Herbert Xu wrote: > > The growth check should stay with the atomic_inc. Something like > this should work: OK I've applied your patch with the atomic_inc move. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt