From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 116D71F3D47 for ; Tue, 7 Jan 2025 21:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736285355; cv=none; b=lUv6KRXiTWI7BqpMs77sDogZYxtfW0FuMrsp/7DD8SKew1qVdhokNknD6IBJeQISA+8iRYuaIRv77O0aUG596lKHn3qnsm9hRgOowS+ky/Iyt15a2uKN5LY1m4plw8B8kfmBXi9bIebbGiwOzZmSzwaTVs0/m6mA57mPcNjqO+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736285355; c=relaxed/simple; bh=OsOEHTJ5U5in1wEkrP4n+Apuq2cXdOq92Jbtdpg90hI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dom+eFul9lLWHv6VHeb0zQYCVWOPEtjA9r6T5akujQvKg6SzUqO3rXyYqJ3F6EGdCwXgK2OY5wmWuL/FTBfB1ZsT0CVXDCpoBBdKY1A4jMsyWAjZ6JOwjx114YqiUNfZ2znIkfe0Dc8+sdy5bgVGQauf168E/G2JrkaJOXV7xZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=z6Sh/5ce; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="z6Sh/5ce" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-21625b4f978so37035ad.0 for ; Tue, 07 Jan 2025 13:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736285353; x=1736890153; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f4yvsaQrMUrrq9MPI20igNRxIiF2iJVeY3n5V9os2bg=; b=z6Sh/5ceB0NwLkiWnIoqYHDiSAh73Ct7jJh2OL9brM9gFkWwqYx+JevbsKywt9Ghpr 8WhCkMiuoBCQvwybEv7nSwZOKwo8eog/DkYApDpBJ3K9dF4GxGxYr0gpKGUjH0gyLwRa qB+EzKDAX+2RJnYQ2wzLCyfwCY8qDNkikAXPYWVOnBEXjPT9bb/NAK1UGUry00XU4HXI 2S0fya6YTwILe/rQA8atOzjqRftAAJwTZcMbSvj8jZmAzS0rnOYoHxmfC8KaYmm+PiSK ue9hvFGgjUI5DtpNF33tLeb/bsIfKYNDgMRzMlbMzbyoYaTuGhpyNsluykbMdT5kLw1Y soYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736285353; x=1736890153; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f4yvsaQrMUrrq9MPI20igNRxIiF2iJVeY3n5V9os2bg=; b=RRXiR2qzz/gJucfRNHFCf+rPYWzLQQfrH75Qgt2828SSdtxzvQ0r4+1rfh22Uclq3h qr2/demrVCsJkCIVHpI6E29B2fqTbAOdFDxaAtB7c9G77ZGJU2AwmRHW+ADdMbnnlOCF rCbU6yIwuWHisedsK2aMNITyaKxdHdEim4+y/b/RBpoP4j8LwvRQXtARQyKtES2Orlxi IzpOfS8k6F0jkxbE+PAz3QwVbXXFePkuHp7yuYXdVR2waqXIGzms1sC39XjDI+muuAxq 6Zx8yUtyRAKGzVIUc8zVdqm7Gbvqdc9PqJDoas3fRmYlExGDGki6r/URehZFoY7Rp4Im 0PCQ== X-Forwarded-Encrypted: i=1; AJvYcCVrCv6anzTkfSJwnqfkBSOyian1zjvJCgrdL8Ccsd1aIPj8b2/DoxDhuqafqSK3ifcp+bgU/Bg=@vger.kernel.org X-Gm-Message-State: AOJu0YywVa08TmdxCekf3io+B7x5RZdQLsoFaWi/+ovx/at5+XwGg4S/ LRcpKvcDwO18XVjR3Pmn+uYQ2csGwPViTn9PxK5IuTPGaYtV9j4dnogN1OJTLQ== X-Gm-Gg: ASbGncvgptAcrZR5VyC/xWg5W5x/zN+fUSB61xgtfFvx0MHVVbtcArd7GVjq7JCsY4Y r/9XHbmj/3mQwXXKQD5GariVi6iYHZb4IuRLVZCZLXigT52+7nuaymVdP6h54PpvJkC0PndBC2q difMUh63wzA8Kgw6NXjZagxsdmroqCHJgetIQ0H1cya911gEsI1xWms9/TJYMmFHlLVmyaC9BRO +EkyyjEeLV6mdtyWttX0iLZEE0aCaYJh106tdwTyhyGq60hLSC8No9Q2I6VRENhyPOBCf+jNSw6 7DWXjc9AzC8Tazb+0MY= X-Google-Smtp-Source: AGHT+IEWDsZlogzDB0XzyYchGeAnkHiHP9TjvYM+KlO+Y/4JXyUM5GmM8Qs2UgpL19SqZeUJKwWCXQ== X-Received: by 2002:a17:902:fb4f:b0:20c:a55b:aef1 with SMTP id d9443c01a7336-21a840fd5damr504765ad.6.1736285353131; Tue, 07 Jan 2025 13:29:13 -0800 (PST) Received: from google.com (57.145.233.35.bc.googleusercontent.com. [35.233.145.57]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8fccd5sm34019862b3a.168.2025.01.07.13.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 13:29:12 -0800 (PST) Date: Tue, 7 Jan 2025 21:29:08 +0000 From: Carlos Llamas To: Li Li Cc: dualli@google.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, donald.hunter@gmail.com, gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, brauner@kernel.org, surenb@google.com, arnd@arndb.de, masahiroy@kernel.org, bagasdotme@gmail.com, horms@kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, hridya@google.com, smoreland@google.com, kernel-team@android.com Subject: Re: [PATCH v11 2/2] binder: report txn errors via generic netlink Message-ID: References: <20241218203740.4081865-1-dualli@chromium.org> <20241218203740.4081865-3-dualli@chromium.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241218203740.4081865-3-dualli@chromium.org> On Wed, Dec 18, 2024 at 12:37:40PM -0800, Li Li wrote: > From: Li Li > @@ -6137,6 +6264,11 @@ static int binder_release(struct inode *nodp, struct file *filp) > > binder_defer_work(proc, BINDER_DEFERRED_RELEASE); > > + if (proc->pid == proc->context->report_portid) { > + proc->context->report_portid = 0; > + proc->context->report_flags = 0; Isn't ->portid the pid from the netlink report manager? How is this ever going to match a certain proc->pid here? Is this manager supposed to _also_ open a regular binder fd? It seems we are tying the cleanup of the netlink interface to the exit of the regular binder device, correct? This seems unfortunate as using the netlink interface should be independent. I was playing around with this patch with my own PoC and now I'm stuck: root@debian:~# ./binder-netlink ./binder-netlink: nlmsgerr No permission to set flags from 1301: Unknown error -1 Is there a different way to reset the protid? -- Carlos Llamas