From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: John Daley <johndale@cisco.com>
Cc: andrew+netdev@lunn.ch, benve@cisco.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, neescoba@cisco.com,
netdev@vger.kernel.org, pabeni@redhat.com, satishkh@cisco.com
Subject: Re: [PATCH net-next 2/2] enic: Obtain the Link speed only after the link comes up
Date: Wed, 8 Jan 2025 07:00:51 +0100 [thread overview]
Message-ID: <Z34UgXz6ota8D27W@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250107195304.2671-1-johndale@cisco.com>
On Tue, Jan 07, 2025 at 11:53:04AM -0800, John Daley wrote:
> >> diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
> >> index 957efe73e41a..49f6cab01ed5 100644
> >> --- a/drivers/net/ethernet/cisco/enic/enic_main.c
> >> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> >> @@ -109,7 +109,7 @@ static struct enic_intr_mod_table mod_table[ENIC_MAX_COALESCE_TIMERS + 1] = {
> >> static struct enic_intr_mod_range mod_range[ENIC_MAX_LINK_SPEEDS] = {
> >> {0, 0}, /* 0 - 4 Gbps */
> >> {0, 3}, /* 4 - 10 Gbps */
> >> - {3, 6}, /* 10 - 40 Gbps */
> >> + {3, 6}, /* 10+ Gbps */
> >
> >Is this on purpose? You didn't mention anything about speed range in
> >commit message. Just wondering, patch looks fine, thanks.
>
> I changed the comment on purpose since it applies to adapters way past
> 40 Gbps nowdays. I should have mentioned the change. Thanks for the
> reveiw.
Reasonable, thanks
> >
> >Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
next prev parent reply other threads:[~2025-01-08 6:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 2:51 [PATCH net-next 0/2] enic: Set link speed only after link up John Daley
2025-01-07 2:51 ` [PATCH net-next 1/2] enic: Move RX coalescing set function John Daley
2025-01-07 5:51 ` Michal Swiatkowski
2025-01-07 13:35 ` Andrew Lunn
2025-01-07 2:51 ` [PATCH net-next 2/2] enic: Obtain the Link speed only after the link comes up John Daley
2025-01-07 5:58 ` Michal Swiatkowski
2025-01-07 19:53 ` John Daley
2025-01-08 6:00 ` Michal Swiatkowski [this message]
2025-01-07 13:37 ` Andrew Lunn
2025-01-07 21:48 ` John Daley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z34UgXz6ota8D27W@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johndale@cisco.com \
--cc=kuba@kernel.org \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).