From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED532221DB6 for ; Thu, 9 Jan 2025 16:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736440049; cv=none; b=gA3ywy83YaVpbp1wM9xL1Zd0hlfMwQg1vF5uRoiCVB5X+6oZkiDVewlwN/VqklHne5JHDfwrQJAjNDR64LPI3hSQk7MExafLuCzzNCcz4LruYplEqr4MDInMQBtAAGtXd/WdL0HhHlpVSNJkz/iVqmQ0acuX58IB5t7Snux4G0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736440049; c=relaxed/simple; bh=LGrMbpGbumR9Cyu0T/UXw/+NPRwpsavIvCI8lKtgS+s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bKtRwEcQEnIjI1hRP3fGf2XRrQud9sWihSDHf4GPMmlXiC47SWpufH+MXXA6Yf0XGHZnWsUgc931O4uqGak4BzS22lchumlXLpVPH60nI13x+Ad4gaVwM2cBTd0yhlzDZhildkxHX+nhTc/ggCa0DaB4cQyq8qEpVdCXlmwXOdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVvNF-0007jf-4e; Thu, 09 Jan 2025 17:27:09 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tVvN9-0000oo-1S; Thu, 09 Jan 2025 17:27:03 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tVvN9-0001L1-14; Thu, 09 Jan 2025 17:27:03 +0100 Date: Thu, 9 Jan 2025 17:27:03 +0100 From: Oleksij Rempel To: Kory Maincent Cc: Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Donald Hunter , Jonathan Corbet , Liam Girdwood , Mark Brown , Thomas Petazzoni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, Kyle Swenson , Dent Project , kernel@pengutronix.de, Maxime Chevallier Subject: Re: [PATCH net-next v2 11/15] net: pse-pd: Add support for PSE device index Message-ID: References: <20250109-b4-feature_poe_arrange-v2-0-55ded947b510@bootlin.com> <20250109-b4-feature_poe_arrange-v2-11-55ded947b510@bootlin.com> <20250109075926.52a699de@kernel.org> <20250109170957.1a4bad9c@kmaincent-XPS-13-7390> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250109170957.1a4bad9c@kmaincent-XPS-13-7390> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org On Thu, Jan 09, 2025 at 05:09:57PM +0100, Kory Maincent wrote: > On Thu, 9 Jan 2025 07:59:26 -0800 > Jakub Kicinski wrote: > > > On Thu, 09 Jan 2025 11:18:05 +0100 Kory Maincent wrote: > > > From: Kory Maincent (Dent Project) > > > > > > Add support for a PSE device index to report the PSE controller index to > > > the user through ethtool. This will be useful for future support of power > > > domains and port priority management. > > > > This index is not used in the series, I see later on you'll add power > > evaluation strategy but that also seems to be within a domain not > > device? > > > > Doesn't it make sense to move patches 11-14 to the next series? > > The other 11 patches seem to my untrained eye to reshuffle existing > > stuff, so they would make sense as a cohesive series. > > Indeed PSE index is used only as user information but there is nothing > correlated. You are right maybe we can add PSE index when we have something > usable for it. No user, means, it is not exposed to the user space, it is not about actual user space users. -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |