From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Marcin Wojtas <marcin.s.wojtas@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: mvpp2: tai: warn once if we fail to update our timestamp
Date: Fri, 3 Jan 2025 09:08:22 +0000 [thread overview]
Message-ID: <Z3epBvz_hgythDYH@shell.armlinux.org.uk> (raw)
In-Reply-To: <Z3ejTGIpl8nF1Ku8@hoboy.vegasvil.org>
On Fri, Jan 03, 2025 at 12:43:56AM -0800, Richard Cochran wrote:
> On Thu, Jan 02, 2025 at 04:26:04PM +0000, Russell King (Oracle) wrote:
>
> > If we fail to read the clock, that will be because the hardware didn't
> > respond to our request to read it, which means the hardware broke in
> > some way. We could make mvpp22_tai_tstamp() fail and not provide
> > timestamps until we have successfully read the HW clock, but we would
> > still want to print a warning to explain why HW timestamps vanish.
>
> Sure, keep the warning, but also block time stamp delivery.
>
> > This is to catch a spurious failure that may only affects an occasoinal
> > attempt to read the HW PTP time. Currently, we would never know,
> > because the kernel is currently completely silent if that were to ever
> > happen.
>
> Is the failure spurious, or is the hardware broken and won't recover?
I have absolutely no idea. I've never seen it happen.
That's why I think going further than I have (and as you are suggesting)
is totally overkill.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-01-03 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 16:34 [PATCH net-next v3] net: mvpp2: tai: warn once if we fail to update our timestamp Russell King
2024-12-14 5:14 ` Richard Cochran
2025-01-02 16:26 ` Russell King (Oracle)
2025-01-03 8:43 ` Richard Cochran
2025-01-03 9:08 ` Russell King (Oracle) [this message]
2025-01-03 9:16 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3epBvz_hgythDYH@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=marcin.s.wojtas@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).