netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Alessandro Zanni <alessandro.zanni87@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, shuah@kernel.org, netdev@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/net/forwarding: teamd command not found
Date: Fri, 10 Jan 2025 04:09:07 +0000	[thread overview]
Message-ID: <Z4CdYzmSn2cySE_h@fedora> (raw)
In-Reply-To: <20250110000752.81062-1-alessandro.zanni87@gmail.com>

On Fri, Jan 10, 2025 at 01:07:44AM +0100, Alessandro Zanni wrote:
> Running "make kselftest TARGETS=net/forwarding" results in several
> occurrences of the same error:
>  ./lib.sh: line 787: teamd: command not found
> 
> Since many tests depends on teamd, this fix stops the tests if the
> teamd command is not installed.
> 
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
> ---
>  tools/testing/selftests/net/forwarding/lib.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
> index 7337f398f9cc..a6a74a4be4bf 100644
> --- a/tools/testing/selftests/net/forwarding/lib.sh
> +++ b/tools/testing/selftests/net/forwarding/lib.sh
> @@ -784,6 +784,7 @@ team_destroy()
>  {
>  	local if_name=$1; shift
>  
> +	require_command $TEAMD
>  	$TEAMD -t $if_name -k
>  }

I saw team_create() has `require_command $TEAMD`. Is some test called
team_destroy() before team_create()?

  reply	other threads:[~2025-01-10  4:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  0:07 [PATCH] selftests/net/forwarding: teamd command not found Alessandro Zanni
2025-01-10  4:09 ` Hangbin Liu [this message]
2025-01-10 14:35   ` Alessandro Zanni
2025-01-11  1:11     ` Hangbin Liu
2025-01-11  1:16     ` Jakub Kicinski
2025-01-13 11:48       ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4CdYzmSn2cySE_h@fedora \
    --to=liuhangbin@gmail.com \
    --cc=alessandro.zanni87@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).