From: Herbert Xu <herbert@gondor.apana.org.au>
To: Breno Leitao <leitao@debian.org>
Cc: Michael Kelley <mhklinux@outlook.com>,
"saeedm@nvidia.com" <saeedm@nvidia.com>,
"tariqt@nvidia.com" <tariqt@nvidia.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Graf <tgraf@suug.ch>, Tejun Heo <tj@kernel.org>,
Hao Luo <haoluo@google.com>, Josh Don <joshdon@google.com>,
Barret Rhoden <brho@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rhashtable: Fix potential deadlock by moving schedule_work outside lock
Date: Fri, 10 Jan 2025 18:07:07 +0800 [thread overview]
Message-ID: <Z4DxS37yJ2EfI_rS@gondor.apana.org.au> (raw)
In-Reply-To: <20250110-diligent-woodpecker-of-promotion-3cbcb1@leitao>
On Fri, Jan 10, 2025 at 01:49:44AM -0800, Breno Leitao wrote:
>
> That is what I though originally as well, but I was not convinced. While
> reading the code, I understood that, if new_tbl is not NULL, then
> PTR_ERR(data) will be -ENOENT.
>
> In which case `net_tbl` will not be NULL, and PTR_ERR(data) != -ENOENT?
The bug arises when an insertion succeeds. So new_tbl is NULL.
The original value of data should have been -ENOENT, however,
it gets overwritten after rhashtable_insert_one (data is now
NULL).
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-01-10 10:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 12:16 [PATCH] rhashtable: Fix potential deadlock by moving schedule_work outside lock Breno Leitao
2024-11-29 5:47 ` Herbert Xu
2024-12-02 20:16 ` Breno Leitao
2024-12-03 20:16 ` Tejun Heo
2024-12-04 1:34 ` Herbert Xu
2024-12-12 12:33 ` Herbert Xu
2024-12-21 9:06 ` Herbert Xu
2025-01-02 10:15 ` Breno Leitao
2025-01-09 3:16 ` Michael Kelley
2025-01-09 10:15 ` Breno Leitao
2025-01-10 9:27 ` Herbert Xu
2025-01-10 9:49 ` Breno Leitao
2025-01-10 10:07 ` Herbert Xu [this message]
2025-01-10 14:46 ` Zaslonko Mikhail
2025-01-10 16:59 ` Michael Kelley
2025-01-10 17:24 ` [v2 PATCH] rhashtable: Fix rhashtable_try_insert test Herbert Xu
2025-01-10 18:22 ` Michael Kelley
2025-01-14 3:15 ` [v3 " Herbert Xu
2025-01-14 11:58 ` Michael Kelley
2025-01-15 15:15 ` Breno Leitao
2025-01-16 9:10 ` Herbert Xu
2025-01-16 11:48 ` Alexander Gordeev
2025-01-17 13:20 ` Zaslonko Mikhail
2025-01-13 19:50 ` [PATCH] rhashtable: Fix potential deadlock by moving schedule_work outside lock Guenter Roeck
2025-01-14 3:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4DxS37yJ2EfI_rS@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=brho@google.com \
--cc=haoluo@google.com \
--cc=joshdon@google.com \
--cc=leitao@debian.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=tgraf@suug.ch \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox