From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org
Subject: Re: [PATCH net-next] net: hide the definition of dev_get_by_napi_id()
Date: Fri, 10 Jan 2025 10:09:51 -0800 [thread overview]
Message-ID: <Z4Fib_xa93pxmhMG@LQ3V64L9R2> (raw)
In-Reply-To: <20250110004924.3212260-1-kuba@kernel.org>
On Thu, Jan 09, 2025 at 04:49:24PM -0800, Jakub Kicinski wrote:
> There are no module callers of dev_get_by_napi_id(),
> and commit d1cacd747768 ("netdev: prevent accessing NAPI instances
> from another namespace") proves that getting NAPI by id
> needs to be done with care. So hide dev_get_by_napi_id().
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: jdamato@fastly.com
> ---
> include/linux/netdevice.h | 1 -
> net/core/dev.c | 2 --
> net/core/dev.h | 1 +
> net/socket.c | 2 ++
> 4 files changed, 3 insertions(+), 3 deletions(-)
Thanks.
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-01-10 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 0:49 [PATCH net-next] net: hide the definition of dev_get_by_napi_id() Jakub Kicinski
2025-01-10 1:29 ` Jacob Keller
2025-01-10 3:54 ` Kalesh Anakkur Purayil
2025-01-10 18:09 ` Joe Damato [this message]
2025-01-11 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4Fib_xa93pxmhMG@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).