From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
jiri@resnulli.us
Subject: Re: [PATCH net-next 01/11] net: add netdev_lock() / netdev_unlock() helpers
Date: Tue, 14 Jan 2025 14:45:08 -0800 [thread overview]
Message-ID: <Z4bo9O5gGG2OBNXJ@LQ3V64L9R2> (raw)
In-Reply-To: <20250114035118.110297-2-kuba@kernel.org>
On Mon, Jan 13, 2025 at 07:51:07PM -0800, Jakub Kicinski wrote:
> Add helpers for locking the netdev instance and use it in drivers
> and the shaper code. This will make grepping for the lock usage
> much easier, as we extend the lock to cover more fields.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: anthony.l.nguyen@intel.com
> CC: przemyslaw.kitszel@intel.com
> CC: jiri@resnulli.us
> ---
> include/linux/netdevice.h | 23 ++++++-
> drivers/net/ethernet/intel/iavf/iavf_main.c | 74 ++++++++++-----------
> drivers/net/netdevsim/ethtool.c | 4 +-
> net/shaper/shaper.c | 6 +-
> 4 files changed, 63 insertions(+), 44 deletions(-)
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-01-14 22:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 3:51 [PATCH net-next 00/11] net: use netdev->lock to protect NAPI Jakub Kicinski
2025-01-14 3:51 ` [PATCH net-next 01/11] net: add netdev_lock() / netdev_unlock() helpers Jakub Kicinski
2025-01-14 12:50 ` Eric Dumazet
2025-01-14 22:45 ` Joe Damato [this message]
2025-01-14 3:51 ` [PATCH net-next 02/11] net: add helpers for lookup and walking netdevs under netdev_lock() Jakub Kicinski
2025-01-14 13:03 ` Eric Dumazet
2025-01-14 14:45 ` Jakub Kicinski
2025-01-14 22:53 ` Joe Damato
2025-01-14 23:51 ` Jakub Kicinski
2025-01-14 3:51 ` [PATCH net-next 03/11] net: make netdev_lock() protect netdev->reg_state Jakub Kicinski
2025-01-14 13:05 ` Eric Dumazet
2025-01-14 22:57 ` Joe Damato
2025-01-14 3:51 ` [PATCH net-next 04/11] net: add netdev->up protected by netdev_lock() Jakub Kicinski
2025-01-14 13:08 ` Eric Dumazet
2025-01-14 23:09 ` Joe Damato
2025-01-14 3:51 ` [PATCH net-next 05/11] net: protect netdev->napi_list with netdev_lock() Jakub Kicinski
2025-01-14 13:09 ` Eric Dumazet
2025-01-14 23:10 ` Joe Damato
2025-01-14 3:51 ` [PATCH net-next 06/11] net: protect NAPI enablement " Jakub Kicinski
2025-01-14 13:14 ` Eric Dumazet
2025-01-14 23:00 ` Francois Romieu
2025-01-14 3:51 ` [PATCH net-next 07/11] net: make netdev netlink ops hold netdev_lock() Jakub Kicinski
2025-01-14 13:16 ` Eric Dumazet
2025-01-14 3:51 ` [PATCH net-next 08/11] net: protect threaded status of NAPI with netdev_lock() Jakub Kicinski
2025-01-14 13:19 ` Eric Dumazet
2025-01-14 3:51 ` [PATCH net-next 09/11] net: protect napi->irq " Jakub Kicinski
2025-01-14 13:20 ` Eric Dumazet
2025-01-14 23:19 ` Joe Damato
2025-01-14 3:51 ` [PATCH net-next 10/11] net: protect NAPI config fields " Jakub Kicinski
2025-01-14 13:23 ` Eric Dumazet
2025-01-14 23:20 ` Joe Damato
2025-01-14 3:51 ` [PATCH net-next 11/11] netdev-genl: remove rtnl_lock protection from NAPI ops Jakub Kicinski
2025-01-14 13:25 ` Eric Dumazet
2025-01-14 23:21 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4bo9O5gGG2OBNXJ@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox