From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4764C25A627 for ; Thu, 16 Jan 2025 23:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737071205; cv=none; b=vAGJczoBZLq+B6a/9o6A4U7FnHU5m72vivmP1i52xJibGK46RE8rOlQK1zDwBDnTv+8CZZTTGYro2WObFn3kSpBfWbT/3mSLdkS+M4wuVrNrsgSh+2YnynhF6APQlU6j9vcnQULysv2rnnF94ZO+B43VNEN4Gw1cddnW9ch85SE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737071205; c=relaxed/simple; bh=UCr2wYW8trWBYhymycVsETSsjPiOXOLwXv7YD7VtZLM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H00D1xTZbfccFTaLX+8a500cNEDXZsJMuyHBDmScwwcWmTHy5qjmYKuBntheg9IcDR2GMjYR7nc619Ky45PuNwRXxRnc3PR/7c34xPWoy1rN8ZWO0w7/4S4SbLwz2UEUZOMcRkcbhFSYLg3DM4mZ9rwvnZHLasnyNktRxgcjnW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mccP5JyT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mccP5JyT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2E17C4CED6; Thu, 16 Jan 2025 23:46:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737071204; bh=UCr2wYW8trWBYhymycVsETSsjPiOXOLwXv7YD7VtZLM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mccP5JyTE0+VuiLc7p7cwbO4AfKrDQ0yuvnNrbGyX4MjjzvxRGSJAXS0iS36E6Ius SVdamKXIksyHoU5S5tdMJc8hkwimowdwdSKrx4ps91v+90EOIVtLEcqv1H+4cNtGJu NjGoDzWMifoc6CHQqpqkRjuNtfgp8HuaW0XVuaCBtnHqTW24eSOPGUh5+nOq0ozqWF JCeEdcYloWPUGsWqolF+aIpTLCZLdz9wpYLco0ZWmDgbAyNCqChlnLooWh2I3t/tPL DPk0asjfiDPKOYTAfBVg/MRdnS3+8d0yCVCUsg4apqfNjvj3c1ZfUheY7DYkbs8Ci/ yDl8RmiWfme4Q== Date: Thu, 16 Jan 2025 15:46:43 -0800 From: Saeed Mahameed To: Jakub Kicinski Cc: "David S. Miller" , Paolo Abeni , Eric Dumazet , Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman , Leon Romanovsky , Dragos Tatulea Subject: Re: [net-next 10/11] net/mlx5e: Implement queue mgmt ops and single channel swap Message-ID: References: <20250116215530.158886-1-saeed@kernel.org> <20250116215530.158886-11-saeed@kernel.org> <20250116152136.53f16ecb@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20250116152136.53f16ecb@kernel.org> On 16 Jan 15:21, Jakub Kicinski wrote: >On Thu, 16 Jan 2025 13:55:28 -0800 Saeed Mahameed wrote: >> +static const struct netdev_queue_mgmt_ops mlx5e_queue_mgmt_ops = { >> + .ndo_queue_mem_size = sizeof(struct mlx5_qmgmt_data), >> + .ndo_queue_mem_alloc = mlx5e_queue_mem_alloc, >> + .ndo_queue_mem_free = mlx5e_queue_mem_free, >> + .ndo_queue_start = mlx5e_queue_start, >> + .ndo_queue_stop = mlx5e_queue_stop, >> +}; > >We need to pay off some technical debt we accrued before we merge more >queue ops implementations. Specifically the locking needs to move from >under rtnl. Sorry, this is not going in for 6.14. What technical debt accrued ? I haven't seen any changes in queue API since bnxt and gve got merged, what changed since then ? mlx5 doesn't require rtnl if this is because of the assert, I can remove it. I don't understand what this series is being deferred for, please elaborate, what do I need to do to get it accepted ? Thanks, Saeed. >-- >pw-bot: defer