Re: [PATCH bpf-next v6 5/5] bpf/selftests: add selftest for bpf_smc_ops

[Saket Kumar Bhaskar <skb99@linux.ibm.com>]

On Wed, Jan 22, 2025 at 10:46:51AM +0800, D. Wythe wrote:
> On Tue, Jan 21, 2025 at 12:12:07PM +0530, Saket Kumar Bhaskar wrote:
> > On Thu, Jan 16, 2025 at 03:44:42PM +0800, D. Wythe wrote:
> > > This tests introduces a tiny smc_ops for filtering SMC connections based on
> > > IP pairs, and also adds a realistic topology model to verify this ops.
> > > 
> > > Also, we can only use SMC loopback under CI test, so an
> > > additional configuration needs to be enabled.
> > > 
> > > Follow the steps below to run this test.
> > > 
> > > make -C tools/testing/selftests/bpf
> > > cd tools/testing/selftests/bpf
> > > sudo ./test_progs -t smc
> > > 
> > > Results shows:
> > > Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
> > > 
> > > Signed-off-by: D. Wythe <alibuda@linux.alibaba.com>
> > > ---
> > >  tools/testing/selftests/bpf/config            |   4 +
> > >  .../selftests/bpf/prog_tests/test_bpf_smc.c   | 397 ++++++++++++++++++
> > >  tools/testing/selftests/bpf/progs/bpf_smc.c   | 117 ++++++
> > >  3 files changed, 518 insertions(+)
> > >  create mode 100644 tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c
> > >  create mode 100644 tools/testing/selftests/bpf/progs/bpf_smc.c
> > > 
> > > diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
> > > index c378d5d07e02..fac2f2a9d02f 100644
> > > --- a/tools/testing/selftests/bpf/config
> > > +++ b/tools/testing/selftests/bpf/config
> > > @@ -113,3 +113,7 @@ CONFIG_XDP_SOCKETS=y
> > > +};
> > Tested this selftest with patches applied on powerpc.
> > 
> > #./test_progs -t bpf_smc
> > 
> > net.smc.ops = linkcheck
> > #27/1    bpf_smc/topo:OK
> > #27      bpf_smc:OK
> > Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
> > 
> > Tested-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
> > 
> > Thanks,
> > Saket
> 
> Hi Saket,
> 
> Thanks for your testing. I hope you don't mind if I add your test-by in
> the next version.
> 
> Best wishes,
> D. Wythe
> 
Fine for me Wythe.

Thanks,
Saket
> > > -- 
> > > 2.45.0
> > >