From: Richard Cochran <richardcochran@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Anna-Maria Gleixner" <anna-maria@linutronix.de>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"John Stultz" <johnstul@us.ibm.com>,
Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"Cyrill Gorcunov" <gorcunov@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] posix-clock: Explicitly handle compat ioctls
Date: Wed, 22 Jan 2025 08:23:35 -0800 [thread overview]
Message-ID: <Z5Ebh4pbOUGh64BS@hoboy.vegasvil.org> (raw)
In-Reply-To: <603100b4-3895-4b7c-a70e-f207dd961550@app.fastmail.com>
On Wed, Jan 22, 2025 at 08:30:51AM +0100, Arnd Bergmann wrote:
> On Tue, Jan 21, 2025, at 23:41, Thomas Weißschuh wrote:
> > Pointer arguments passed to ioctls need to pass through compat_ptr() to
> > work correctly on s390; as explained in Documentation/driver-api/ioctl.rst.
> > Plumb the compat_ioctl callback through 'struct posix_clock_operations'
> > and handle the different ioctls cmds in the new ptp_compat_ioctl().
> >
> > Using compat_ptr_ioctl is not possible.
> > For the commands PTP_ENABLE_PPS/PTP_ENABLE_PPS2 on s390
> > it would corrupt the argument 0x80000000, aka BIT(31) to zero.
> >
> > Fixes: 0606f422b453 ("posix clocks: Introduce dynamic clocks")
> > Fixes: d94ba80ebbea ("ptp: Added a brand new class driver for ptp clocks.")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>
> This looks correct to me,
I'm not familiar with s390, but I can remember that the compat ioctl
was nixed during review.
https://lore.kernel.org/lkml/201012161716.42520.arnd@arndb.de/
https://lore.kernel.org/lkml/alpine.LFD.2.00.1012161939340.12146@localhost6.localdomain6/
Can you explain what changed or what was missed?
Thanks,
Richard
next prev parent reply other threads:[~2025-01-22 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 22:41 [PATCH] posix-clock: Explicitly handle compat ioctls Thomas Weißschuh
2025-01-22 6:59 ` Cyrill Gorcunov
2025-01-22 7:30 ` Arnd Bergmann
2025-01-22 16:23 ` Richard Cochran [this message]
2025-01-22 16:48 ` Thomas Weißschuh
2025-01-22 17:15 ` Arnd Bergmann
2025-01-23 16:22 ` Thomas Weißschuh
2025-01-23 21:10 ` Arnd Bergmann
2025-01-22 9:52 ` Simon Horman
2025-01-22 16:39 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5Ebh4pbOUGh64BS@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=gorcunov@gmail.com \
--cc=johnstul@us.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).