From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE8020C024 for ; Thu, 23 Jan 2025 08:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737621598; cv=none; b=b+XPI8hSALsSyqNI3O8jZnafey7011ht8iyAOQfRoa9wj+XHnwtF9Wj36WqWMv3c5ytSVjM92W0gDeBo0A1rsAKTUsJJxfAiq2Ob752Q22+wYVSC+4zrktiktbYiCw6RI7VwETmOrK6eWCNskzPgg2E7E5jlKWdQwWUqlaIq1EA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737621598; c=relaxed/simple; bh=YrJfmBJfRM5BJl7DU/6G4DUWFE24IFCnHoyZKUXHlas=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mwc2KmkNUiJdRhlztiO6JLWgYp8zSl8PPAXrCkmUC9S/1p9OLA8uu86DcxtuRSkNE3FuBomOlvAzvZACYfVUQrmS/J4mRWqn8TOvMhBhC/Exru5NKu9yG4IFdW3GR6Fm1siRbgpCA6srdmGuQbkEC8+kaMYzqhZonBmZy6zByjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I4fvgGUM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I4fvgGUM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737621595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GiFqxgggPoN9+s+nMZCrGcnPpT3g6d2dyyCadPevlp4=; b=I4fvgGUMlDguu+wQ7E8C88mJxXin37i/MNQOVdfO6NvWlpjjK6YIwitpXKjdIA/pbNbZ0F KHtDWBnyL6ACcW/z6y6hzCcIqqNnf0SpHFyz9bnudkOIgQSm6Qaco9Hv+1JFaP+bXjut77 GKEEjs/lYpi3ZgISzpVCOOh7KlHGhqU= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-dw1Ok2SGMD6aWZ9FUpWYJA-1; Thu, 23 Jan 2025 03:39:54 -0500 X-MC-Unique: dw1Ok2SGMD6aWZ9FUpWYJA-1 X-Mimecast-MFC-AGG-ID: dw1Ok2SGMD6aWZ9FUpWYJA Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2ef9da03117so2368892a91.1 for ; Thu, 23 Jan 2025 00:39:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737621593; x=1738226393; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GiFqxgggPoN9+s+nMZCrGcnPpT3g6d2dyyCadPevlp4=; b=mDA5giqgXEyukXkbIIez4bU/LXW9+QEDdVOE5jZhbTv6WRH/cAsDlPX2wQXw59LZkq RdhDNVF7bWAYbzz1B0k+m4xt1aupcK4NL63q5RTf9Mp7Vv5EUWPi7vh/yCN6iofhGLG7 qfAvsaXya9XzT+i4esoo0qLtHK2s0B4smYlxjwIrKItXbp4OZP01mOwLdVEFtWgsJ762 vhiSRYfDPStQZwaWJhmhGuFTlgtTcmcKfNHrudeTGP1C7yein7N2cCyIBnTqArINVQlJ sdIC4s7wpLNCVlHx5S3DgEz3vrl8HNMIgi/ARKjkZRojyecxVftt2FzNSiXWWxBdR5QH Tk7g== X-Forwarded-Encrypted: i=1; AJvYcCWtupe7RcwbuBz6+DPL2NXYh5TcyE+V3QWMUVNxOm2YBngpWPTXgu6kKad+f0umTNbQYhjBWis=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6Xto/EhfSzgn1r5FdZxAd0MpZq6/7OHlYdZGVLnQRw4Fs0rB+ s5trIVXWYKensjxwD9gLH4Q+FAcR5rUvrR62dfk7OR1jPcdvMSNY8qlygk4EdxRx9bmE1I3um7T Slu8NLR3Gdtz6pKIZfxG4+YQezObrVt3aA+bhAidab3fFHZbXqUtN6KSO+Jk0Gjs= X-Gm-Gg: ASbGncsscePmdq9x+edc7hruGiP/JZAmQp8VR6zkIvdrwEQnHHjUXfwGSMkWYKMT0ec z6+SIzUiqgK0gBRocCTfAvItZRi2PVYTgfqa29EZe+bPytMdR6YMtswFo3sJ0d6DMs6XnHZl+TZ j/Ae/hkGzdn/xJ4OGpNRaa2pcaOAHOWUWA2ZDAWVXWBhNpH1y2q2sz5HNnk8N3G8NbXvR30Bo2H stBPZpSRGdW53BcYH6hI7OkfabJ3CIh+TYBMyLwbs2XLzRT/o132EBlzYTp0RbDTCHT X-Received: by 2002:a17:90b:1f92:b0:2ee:8427:4b02 with SMTP id 98e67ed59e1d1-2f782d4ee70mr38271547a91.28.1737621593087; Thu, 23 Jan 2025 00:39:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhMZaYjsqNmySTRYcUMtYOJ74eIJfObrd1yiHY1EySAIXMN2gcyZKJ0eJU5K1ZveJIHc7pjw== X-Received: by 2002:a17:90b:1f92:b0:2ee:8427:4b02 with SMTP id 98e67ed59e1d1-2f782d4ee70mr38271536a91.28.1737621592831; Thu, 23 Jan 2025 00:39:52 -0800 (PST) Received: from fedora ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7e6b9b1desm3305192a91.47.2025.01.23.00.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2025 00:39:52 -0800 (PST) Date: Thu, 23 Jan 2025 08:39:47 +0000 From: Hangbin Liu To: Jan Stancek Cc: matttbe@kernel.org, martineau@kernel.org, eliang@kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests: mptcp: extend CFLAGS to keep options from environment Message-ID: References: <7abc701da9df39c2d6cd15bc3cf9e6cee445cb96.1737621162.git.jstancek@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7abc701da9df39c2d6cd15bc3cf9e6cee445cb96.1737621162.git.jstancek@redhat.com> On Thu, Jan 23, 2025 at 09:35:42AM +0100, Jan Stancek wrote: > Package build environments like Fedora rpmbuild introduced hardening > options (e.g. -pie -Wl,-z,now) by passing a -spec option to CFLAGS > and LDFLAGS. > > mptcp Makefile currently overrides CFLAGS but not LDFLAGS, which leads > to a mismatch and build failure, for example: > make[1]: *** [../../lib.mk:222: tools/testing/selftests/net/mptcp/mptcp_sockopt] Error 1 > /usr/bin/ld: /tmp/ccqyMVdb.o: relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a PIE object; recompile with -fPIE > /usr/bin/ld: failed to set dynamic section sizes: bad value > collect2: error: ld returned 1 exit status > > Signed-off-by: Jan Stancek > --- > tools/testing/selftests/net/mptcp/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/selftests/net/mptcp/Makefile > index 8e3fc05a5397..9706bc73809f 100644 > --- a/tools/testing/selftests/net/mptcp/Makefile > +++ b/tools/testing/selftests/net/mptcp/Makefile > @@ -2,7 +2,7 @@ > > top_srcdir = ../../../../.. > > -CFLAGS = -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(KHDR_INCLUDES) > +CFLAGS += -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(KHDR_INCLUDES) > > TEST_PROGS := mptcp_connect.sh pm_netlink.sh mptcp_join.sh diag.sh \ > simult_flows.sh mptcp_sockopt.sh userspace_pm.sh > -- > 2.43.0 > Reviewed-by: Hangbin Liu