Re: [net-next 10/11] net/mlx5e: Implement queue mgmt ops and single channel swap

Saeed Mahameed
2025-01-16T23:46:45Z

On 16 Jan 15:21, Jakub Kicinski wrote:
>On Thu, 16 Jan 2025 13:55:28 -0800 Saeed Mahameed wrote:
>> +static const struct netdev_queue_mgmt_ops mlx5e_queue_mgmt_ops = {
>> + .ndo_queue_mem_size = sizeof(struct mlx5_qmgmt_data),
>> + .ndo_queue_mem_alloc = mlx5e_queue_mem_alloc,
>> + .ndo_queue_mem_free = mlx5e_queue_mem_free,
>> + .ndo_queue_start = mlx5e_queue_start,
>> + .ndo_queue_stop = mlx5e_queue_stop,
>> +};
>
>We need to pay off some technical debt we accrued before we merge more
>queue ops implementations. Specifically the locking needs to move from
>under rtnl. Sorry, this is not going in for 6.14.

What technical debt accrued ? I haven't seen any changes in queue API since
bnxt and gve got merged, what changed since then ?

mlx5 doesn't require rtnl if this is because of the assert, I can remove
it. I don't understand what this series is being deferred for, please
elaborate, what do I need to do to get it accepted ?

Thanks,
Saeed.

>--
>pw-bot: defer