From: Cong Wang <xiyou.wangcong@gmail.com>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, jiri@resnulli.us,
quanglex97@gmail.com, mincho@theori.io,
Cong Wang <cong.wang@bytedance.com>
Subject: Re: [Patch net 2/4] Add test case to check for pfifo_tail_enqueue() behaviour when limit == 0
Date: Sat, 25 Jan 2025 19:20:42 -0800 [thread overview]
Message-ID: <Z5WqCnOiSF72PGws@pop-os.localdomain> (raw)
In-Reply-To: <20250124113743.GA34605@kernel.org>
On Fri, Jan 24, 2025 at 11:37:43AM +0000, Simon Horman wrote:
> On Thu, Jan 23, 2025 at 10:07:38PM -0800, Cong Wang wrote:
> > From: Quang Le <quanglex97@gmail.com>
> >
> > When limit == 0, pfifo_tail_enqueue() must drop new packet and
> > increase dropped packets count of scheduler.
> >
> > Signed-off-by: Quang Le <quanglex97@gmail.com>
> > Signed-off-by: Cong Wang <cong.wang@bytedance.com>
>
> Hi Cong, all,
>
> This test is reporting "not ok" in the Netdev CI.
>
> # not ok 577 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0
> # Could not match regex pattern. Verify command output:
> # qdisc pfifo_head_drop 1: root refcnt 2 limit 0p
> # Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
> # backlog 0b 0p requeues 0
Oops... It worked on my side, let me take a look.
Thanks for reporting!
next prev parent reply other threads:[~2025-01-26 3:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 6:07 [Patch net 0/4] net_sched: two security bug fixes and test cases Cong Wang
2025-01-24 6:07 ` [Patch net 1/4] pfifo_tail_enqueue: Drop new packet when sch->limit == 0 Cong Wang
2025-01-30 11:17 ` Jamal Hadi Salim
2025-01-31 21:53 ` Cong Wang
2025-01-24 6:07 ` [Patch net 2/4] Add test case to check for pfifo_tail_enqueue() behaviour when limit " Cong Wang
2025-01-24 11:37 ` Simon Horman
2025-01-26 3:20 ` Cong Wang [this message]
2025-01-26 3:52 ` Cong Wang
2025-01-27 17:54 ` Simon Horman
2025-01-24 6:07 ` [Patch net 3/4] netem: update sch->q.qlen before qdisc_tree_reduce_backlog() Cong Wang
2025-01-24 6:07 ` [Patch net 4/4] selftests/tc-testing: add tests for qdisc_tree_reduce_backlog Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5WqCnOiSF72PGws@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=cong.wang@bytedance.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mincho@theori.io \
--cc=netdev@vger.kernel.org \
--cc=quanglex97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox