Re: Move airoha in a dedicated folder

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2488 bytes --]

> > Hi,
> > may I push for a dedicated Airoha directory? (/net/ethernet/airoha ?)
> > 
> > With new SoC it seems Airoha is progressively detaching from Mediatek.
> 
> The vendor name is actually not very relevant. Linux has a much longer
> life than most vendors. Assets get bought and sold, but they keep the
> same name in Linux simply to make Maintenance simpler. FEC has not
> been part of Freescale for a long time. Microsemi and micrel are part
> of microchip, but we still call them microsemi and micrel, because who
> knows, microchip might soon be eaten by somebody bigger, or broken up?
> 
> > Putting stuff in ethernet/mediatek/airoha would imply starting to
> > use format like #include "../stuff.h" and maybe we would start to
> > import stuff from mediatek that should not be used by airoha.
> 
> obj-$(CONFIG_NET_AIROHA) += airoha_eth.o
> 
> #include <linux/etherdevice.h>
> #include <linux/iopoll.h>
> #include <linux/kernel.h>
> #include <linux/netdevice.h>
> #include <linux/of.h>
> #include <linux/of_net.h>
> #include <linux/platform_device.h>
> #include <linux/reset.h>
> #include <linux/tcp.h>
> #include <linux/u64_stats_sync.h>
> #include <net/dsa.h>
> #include <net/page_pool/helpers.h>
> #include <net/pkt_cls.h>
> #include <uapi/linux/ppp_defs.h>
> 
> I don't see anything being shared. Maybe that is just because those
> features are not implemented yet? But if there is sharing, we do want
> code to be shared, rather than copy/paste bugs and code between
> drivers.
> 
> Maybe drivers/net/ethernet/wangxun is a good model to follow, although
> i might put the headers in include/linux/net/mediatek rather than do
> relative #includes.

I do not think we can reuse many code from MTK codebase since, even if the
Packet Switch Engine (PSE)/Packet Processor Engine (PPE) architecture is
similar to MTK one (you can find a diagram here [0]), Airoha SoC runs a NPU
to configure the PPE module and we can't access the hw directly as we do
for MTK. Moreover, the PPE entry layout is slightly different and we could
reuse just some MTK definitions. For these reasons I guess it does not worth
to have a structure similar to wangxun's one (lib + hw specific code), maybe
just move the driver in a dedicated folder? (e.g. drivers/net/ethernet/airoha)

Regards,
Lorenzo

[0] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=23020f04932701d5c8363e60756f12b43b8ed752

> 
> 	Andrew


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]