From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "sreedevi.joshi" <joshisre@ecsmtp.an.intel.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
Sreedevi Joshi <sreedevi.joshi@intel.com>
Subject: Re: [PATCH net] phy: fix null pointer issue in phy_attach_direct()
Date: Wed, 29 Jan 2025 19:29:59 +0000 [thread overview]
Message-ID: <Z5qBt4Cnds7NvBea@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250129183638.695010-1-sreedevi.joshi@intel.com>
On Wed, Jan 29, 2025 at 12:36:38PM -0600, sreedevi.joshi wrote:
> From: Sreedevi Joshi <sreedevi.joshi@intel.com>
>
> When attaching a fixed phy to devices like veth, it is
> possible that there is no parent. The logic in
> phy_attach_direct() tries to access the driver member
> without checking for the null. This causes segfault in the
> case of fixed phy.
Kernel mode doesn't segfault. That's a userspace thing. Kernel mode
oopses.
I'm confused. You mention veth, which presumably is drivers/net/veth.c.
Grepping this driver for "phy" returns nothing. So how can veth be
broken by a phylib change?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-01-29 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 18:36 [PATCH net] phy: fix null pointer issue in phy_attach_direct() sreedevi.joshi
2025-01-29 19:14 ` Andrew Lunn
2025-01-30 19:10 ` Joshi, Sreedevi
2025-01-30 19:52 ` Andrew Lunn
2025-01-31 14:57 ` Joshi, Sreedevi
2025-01-29 19:29 ` Russell King (Oracle) [this message]
2025-01-30 19:18 ` Joshi, Sreedevi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5qBt4Cnds7NvBea@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=joshisre@ecsmtp.an.intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sreedevi.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).