* [PATCH] ice: Add check for devm_kzalloc()
@ 2025-01-31 1:38 Jiasheng Jiang
2025-01-31 6:17 ` Michal Swiatkowski
2025-02-02 1:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jiasheng Jiang @ 2025-01-31 1:38 UTC (permalink / raw)
To: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, michal.swiatkowski, horms,
wojciech.drewek, piotr.raczynski, mateusz.polchlopek,
pawel.kaminski, michal.wilczynski
Cc: intel-wired-lan, netdev, linux-kernel, Jiasheng Jiang
Add check for the return value of devm_kzalloc() to guarantee the success
of allocation.
Fixes: 42c2eb6b1f43 ("ice: Implement devlink-rate API")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
drivers/net/ethernet/intel/ice/devlink/devlink.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c b/drivers/net/ethernet/intel/ice/devlink/devlink.c
index d116e2b10bce..dbdb83567364 100644
--- a/drivers/net/ethernet/intel/ice/devlink/devlink.c
+++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c
@@ -981,6 +981,9 @@ static int ice_devlink_rate_node_new(struct devlink_rate *rate_node, void **priv
/* preallocate memory for ice_sched_node */
node = devm_kzalloc(ice_hw_to_dev(pi->hw), sizeof(*node), GFP_KERNEL);
+ if (!node)
+ return -ENOMEM;
+
*priv = node;
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ice: Add check for devm_kzalloc()
2025-01-31 1:38 [PATCH] ice: Add check for devm_kzalloc() Jiasheng Jiang
@ 2025-01-31 6:17 ` Michal Swiatkowski
2025-02-02 1:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Michal Swiatkowski @ 2025-01-31 6:17 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, horms, wojciech.drewek, piotr.raczynski,
mateusz.polchlopek, pawel.kaminski, michal.wilczynski,
intel-wired-lan, netdev, linux-kernel
On Fri, Jan 31, 2025 at 01:38:32AM +0000, Jiasheng Jiang wrote:
> Add check for the return value of devm_kzalloc() to guarantee the success
> of allocation.
>
> Fixes: 42c2eb6b1f43 ("ice: Implement devlink-rate API")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
> drivers/net/ethernet/intel/ice/devlink/devlink.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> index d116e2b10bce..dbdb83567364 100644
> --- a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> @@ -981,6 +981,9 @@ static int ice_devlink_rate_node_new(struct devlink_rate *rate_node, void **priv
>
> /* preallocate memory for ice_sched_node */
> node = devm_kzalloc(ice_hw_to_dev(pi->hw), sizeof(*node), GFP_KERNEL);
> + if (!node)
> + return -ENOMEM;
> +
Thanks for fixing:
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> *priv = node;
>
> return 0;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ice: Add check for devm_kzalloc()
2025-01-31 1:38 [PATCH] ice: Add check for devm_kzalloc() Jiasheng Jiang
2025-01-31 6:17 ` Michal Swiatkowski
@ 2025-02-02 1:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-02 1:20 UTC (permalink / raw)
To: Jiasheng Jiang
Cc: anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev, davem,
edumazet, kuba, pabeni, michal.swiatkowski, horms,
wojciech.drewek, piotr.raczynski, mateusz.polchlopek,
pawel.kaminski, michal.wilczynski, intel-wired-lan, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 31 Jan 2025 01:38:32 +0000 you wrote:
> Add check for the return value of devm_kzalloc() to guarantee the success
> of allocation.
>
> Fixes: 42c2eb6b1f43 ("ice: Implement devlink-rate API")
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> ---
> drivers/net/ethernet/intel/ice/devlink/devlink.c | 3 +++
> 1 file changed, 3 insertions(+)
Here is the summary with links:
- ice: Add check for devm_kzalloc()
https://git.kernel.org/netdev/net/c/a8aa6a6ddce9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-02 1:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-31 1:38 [PATCH] ice: Add check for devm_kzalloc() Jiasheng Jiang
2025-01-31 6:17 ` Michal Swiatkowski
2025-02-02 1:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).