From: Joe Damato <jdamato@fastly.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Mina Almasry <almasrymina@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] netdev-genl: Elide napi_id when not present
Date: Tue, 4 Feb 2025 10:56:02 -0800 [thread overview]
Message-ID: <Z6JiwvIvMSVaeM23@LQ3V64L9R2> (raw)
In-Reply-To: <CANn89iJ=8inHbr+qQKifcX=m5=TfN8+MELDM_Ho8-mdA156UPw@mail.gmail.com>
On Tue, Feb 04, 2025 at 07:53:51PM +0100, Eric Dumazet wrote:
> On Tue, Feb 4, 2025 at 7:28 PM Joe Damato <jdamato@fastly.com> wrote:
> >
> > On Tue, Feb 04, 2025 at 06:41:34AM +0100, Eric Dumazet wrote:
> > > On Mon, Feb 3, 2025 at 8:17 PM Joe Damato <jdamato@fastly.com> wrote:
[...]
> > >
> > > Hi Joe
> > >
> > > This might be time to add helpers, we now have these checks about
> > > MIN_NAPI_ID all around the places.
> >
> > I'm not sure what the right etiquette is; I was thinking of just
> > taking the patch you proposed below and submitting it with you as
> > the author with my Reviewed-by.
> >
> > Is that OK and if so, are you OK with the commit message?
>
> Oh no worries, please grab the patch completely, I will add my usual
> 'Reviewed-by' tag.
OK, will do. Thanks for the guidance.
prev parent reply other threads:[~2025-02-04 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 19:17 [PATCH net-next v2] netdev-genl: Elide napi_id when not present Joe Damato
2025-02-03 19:50 ` Samudrala, Sridhar
2025-02-04 5:41 ` Eric Dumazet
2025-02-04 13:02 ` Paolo Abeni
2025-02-04 18:13 ` Joe Damato
2025-02-04 18:28 ` Joe Damato
2025-02-04 18:53 ` Eric Dumazet
2025-02-04 18:56 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6JiwvIvMSVaeM23@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=almasrymina@google.com \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).