Re: [PATCH net-next v3 2/4] net: Create separate gro_flush helper function

[Joe Damato <jdamato@fastly.com>]

On Wed, Feb 05, 2025 at 12:10:50AM +0000, Samiullah Khawaja wrote:
> Move multiple copies of same code snippet doing `gro_flush` and
> `gro_normal_list` into a separate helper function.

Like the other patch, this one could probably be sent on its own. I
think if you want to include it in your series, that's fine, but I
think factoring this out into helpers is good clean up.

> Signed-off-by: Samiullah Khawaja <skhawaja@google.com>
> ---
>  net/core/dev.c | 28 +++++++++++++---------------
>  1 file changed, 13 insertions(+), 15 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 50fb234dd7a0..d5dcf9dd6225 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6484,6 +6484,17 @@ static void skb_defer_free_flush(struct softnet_data *sd)
>  	}
>  }
>  
> +static void __napi_gro_flush_helper(struct napi_struct *napi)

I wonder if this could be changed to take a boolean as a second arg
then you could also use this helper in napi_complete_done in
addition to the locations you've already cleaned up?