From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Yanteng Si <si.yanteng@linux.dev>
Cc: Jakub Kicinski <kuba@kernel.org>,
Steven Price <steven.price@arm.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
"David S. Miller" <davem@davemloft.net>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Jose Abreu <joabreu@synopsys.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
Furong Xu <0x1207@gmail.com>, Petr Tesarik <petr@tesarici.cz>,
Serge Semin <fancer.lancer@gmail.com>,
Xi Ruoyao <xry111@xry111.site>
Subject: Re: [PATCH] net: stmmac: Allow zero for [tr]x_fifo_size
Date: Wed, 5 Feb 2025 14:39:35 +0000 [thread overview]
Message-ID: <Z6N4J-_C3lq5a_VQ@shell.armlinux.org.uk> (raw)
In-Reply-To: <f728a006-e588-4eab-b667-b1ff7dfd66c5@linux.dev>
On Wed, Feb 05, 2025 at 10:22:00PM +0800, Yanteng Si wrote:
>
> 在 2/4/25 06:23, Jakub Kicinski 写道:
> > On Mon, 3 Feb 2025 11:16:34 +0000 Russell King (Oracle) wrote:
> > > > I've no opinion whether the original series "had value" - I'm just
> > > > trying to fix the breakage that entailed. My first attempt at a patch
> > > > was indeed a (partial) revert, but Andrew was keen to find a better
> > > > solution[1].
> > > There are two ways to fix the breakage - either revert the original
> > > patches (which if they have little value now would be the sensible
> > > approach IMHO)
> > +1, I also vote revert FWIW
>
> +1, same here.
>
>
> For a driver that runs on so much hardware, we need to act
>
> cautiously. A crucial prerequisite is that code changes must
>
> never cause some hardware to malfunction. I was too simplistic
>
> in my thinking when reviewing this before, and I sincerely
>
> apologize for that.
>
>
> Steven, thank you for your tests, Let's revert it.
https://lore.kernel.org/r/E1tfeyR-003YGJ-Gb@rmk-PC.armlinux.org.uk
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-02-05 14:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 9:34 [PATCH] net: stmmac: Allow zero for [tr]x_fifo_size Steven Price
2025-02-03 10:38 ` Russell King (Oracle)
2025-02-03 11:01 ` Steven Price
2025-02-03 11:16 ` Russell King (Oracle)
2025-02-03 11:40 ` Steven Price
2025-02-03 22:23 ` Jakub Kicinski
2025-02-05 14:22 ` Yanteng Si
2025-02-05 14:39 ` Russell King (Oracle) [this message]
2025-02-06 7:05 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6N4J-_C3lq5a_VQ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petr@tesarici.cz \
--cc=si.yanteng@linux.dev \
--cc=steven.price@arm.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).