* [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6
@ 2025-02-05 11:44 Ted Chen
2025-02-05 12:12 ` Nikolay Aleksandrov
0 siblings, 1 reply; 5+ messages in thread
From: Ted Chen @ 2025-02-05 11:44 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, andrew+netdev
Cc: netdev, Ted Chen, Ido Schimmel
Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c
invoke vxlan_rcv() to process packets.
The comment aligns with that for vxlan_err_lookup().
Cc: Ido Schimmel <idosch@idosch.org>
Signed-off-by: Ted Chen <znscnchen@gmail.com>
---
drivers/net/vxlan/vxlan_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 5ef40ac816cc..8bdf91d1fdfe 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
return err <= 1;
}
-/* Callback from net/ipv4/udp.c to receive packets */
+/* Callback from net/ipv{4,6}/udp.c to receive packets */
static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
{
struct vxlan_vni_node *vninode = NULL;
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6
2025-02-05 11:44 [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6 Ted Chen
@ 2025-02-05 12:12 ` Nikolay Aleksandrov
2025-02-05 12:40 ` Ted Chen
0 siblings, 1 reply; 5+ messages in thread
From: Nikolay Aleksandrov @ 2025-02-05 12:12 UTC (permalink / raw)
To: Ted Chen, davem, edumazet, kuba, pabeni, andrew+netdev
Cc: netdev, Ido Schimmel
On 2/5/25 13:44, Ted Chen wrote:
> Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c
> invoke vxlan_rcv() to process packets.
>
> The comment aligns with that for vxlan_err_lookup().
>
> Cc: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Ted Chen <znscnchen@gmail.com>
> ---
> drivers/net/vxlan/vxlan_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index 5ef40ac816cc..8bdf91d1fdfe 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
> return err <= 1;
> }
>
> -/* Callback from net/ipv4/udp.c to receive packets */
> +/* Callback from net/ipv{4,6}/udp.c to receive packets */
> static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
> {
> struct vxlan_vni_node *vninode = NULL;
Your subject has a typo
s/inlucde/include
IMO these comments are unnecessary, encap_rcv callers are trivial to find.
Cheers,
Nik
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6
2025-02-05 12:12 ` Nikolay Aleksandrov
@ 2025-02-05 12:40 ` Ted Chen
2025-02-05 12:48 ` Nikolay Aleksandrov
0 siblings, 1 reply; 5+ messages in thread
From: Ted Chen @ 2025-02-05 12:40 UTC (permalink / raw)
To: Nikolay Aleksandrov
Cc: davem, edumazet, kuba, pabeni, andrew+netdev, netdev,
Ido Schimmel
On Wed, Feb 05, 2025 at 02:12:50PM +0200, Nikolay Aleksandrov wrote:
> On 2/5/25 13:44, Ted Chen wrote:
> > Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c
> > invoke vxlan_rcv() to process packets.
> >
> > The comment aligns with that for vxlan_err_lookup().
> >
> > Cc: Ido Schimmel <idosch@idosch.org>
> > Signed-off-by: Ted Chen <znscnchen@gmail.com>
> > ---
> > drivers/net/vxlan/vxlan_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> > index 5ef40ac816cc..8bdf91d1fdfe 100644
> > --- a/drivers/net/vxlan/vxlan_core.c
> > +++ b/drivers/net/vxlan/vxlan_core.c
> > @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
> > return err <= 1;
> > }
> >
> > -/* Callback from net/ipv4/udp.c to receive packets */
> > +/* Callback from net/ipv{4,6}/udp.c to receive packets */
> > static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
> > {
> > struct vxlan_vni_node *vninode = NULL;
>
> Your subject has a typo
> s/inlucde/include
Oops. Sorry for that.
> IMO these comments are unnecessary, encap_rcv callers are trivial to find.
I'm fine with either way. No comment is better than a wrong comment.
Please let me know if I need to send a new version to correct the subject or
remove the comments for both vxlan_rcv() and vxlan_err_lookup().
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6
2025-02-05 12:40 ` Ted Chen
@ 2025-02-05 12:48 ` Nikolay Aleksandrov
2025-02-05 17:48 ` Ido Schimmel
0 siblings, 1 reply; 5+ messages in thread
From: Nikolay Aleksandrov @ 2025-02-05 12:48 UTC (permalink / raw)
To: Ted Chen; +Cc: davem, edumazet, kuba, pabeni, andrew+netdev, netdev,
Ido Schimmel
On 2/5/25 14:40, Ted Chen wrote:
> On Wed, Feb 05, 2025 at 02:12:50PM +0200, Nikolay Aleksandrov wrote:
>> On 2/5/25 13:44, Ted Chen wrote:
>>> Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c
>>> invoke vxlan_rcv() to process packets.
>>>
>>> The comment aligns with that for vxlan_err_lookup().
>>>
>>> Cc: Ido Schimmel <idosch@idosch.org>
>>> Signed-off-by: Ted Chen <znscnchen@gmail.com>
>>> ---
>>> drivers/net/vxlan/vxlan_core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
>>> index 5ef40ac816cc..8bdf91d1fdfe 100644
>>> --- a/drivers/net/vxlan/vxlan_core.c
>>> +++ b/drivers/net/vxlan/vxlan_core.c
>>> @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
>>> return err <= 1;
>>> }
>>>
>>> -/* Callback from net/ipv4/udp.c to receive packets */
>>> +/* Callback from net/ipv{4,6}/udp.c to receive packets */
>>> static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
>>> {
>>> struct vxlan_vni_node *vninode = NULL;
>>
>> Your subject has a typo
>> s/inlucde/include
> Oops. Sorry for that.
>
>> IMO these comments are unnecessary, encap_rcv callers are trivial to find.
> I'm fine with either way. No comment is better than a wrong comment.
> Please let me know if I need to send a new version to correct the subject or
> remove the comments for both vxlan_rcv() and vxlan_err_lookup().
>
Up to you, I don't have a strong preference. You have to wait 24 hours
before posting another version anyway, so you have time to decide. :)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6
2025-02-05 12:48 ` Nikolay Aleksandrov
@ 2025-02-05 17:48 ` Ido Schimmel
0 siblings, 0 replies; 5+ messages in thread
From: Ido Schimmel @ 2025-02-05 17:48 UTC (permalink / raw)
To: Nikolay Aleksandrov
Cc: Ted Chen, davem, edumazet, kuba, pabeni, andrew+netdev, netdev
On Wed, Feb 05, 2025 at 02:48:36PM +0200, Nikolay Aleksandrov wrote:
> On 2/5/25 14:40, Ted Chen wrote:
> > On Wed, Feb 05, 2025 at 02:12:50PM +0200, Nikolay Aleksandrov wrote:
> >> On 2/5/25 13:44, Ted Chen wrote:
> >>> Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c
> >>> invoke vxlan_rcv() to process packets.
> >>>
> >>> The comment aligns with that for vxlan_err_lookup().
> >>>
> >>> Cc: Ido Schimmel <idosch@idosch.org>
> >>> Signed-off-by: Ted Chen <znscnchen@gmail.com>
> >>> ---
> >>> drivers/net/vxlan/vxlan_core.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> >>> index 5ef40ac816cc..8bdf91d1fdfe 100644
> >>> --- a/drivers/net/vxlan/vxlan_core.c
> >>> +++ b/drivers/net/vxlan/vxlan_core.c
> >>> @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
> >>> return err <= 1;
> >>> }
> >>>
> >>> -/* Callback from net/ipv4/udp.c to receive packets */
> >>> +/* Callback from net/ipv{4,6}/udp.c to receive packets */
> >>> static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
> >>> {
> >>> struct vxlan_vni_node *vninode = NULL;
> >>
> >> Your subject has a typo
> >> s/inlucde/include
> > Oops. Sorry for that.
> >
> >> IMO these comments are unnecessary, encap_rcv callers are trivial to find.
> > I'm fine with either way. No comment is better than a wrong comment.
> > Please let me know if I need to send a new version to correct the subject or
> > remove the comments for both vxlan_rcv() and vxlan_err_lookup().
> >
>
> Up to you, I don't have a strong preference. You have to wait 24 hours
> before posting another version anyway, so you have time to decide. :)
Looks like nobody will miss these comments, so I think they can be
safely removed in v2 :)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-05 17:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 11:44 [PATCH net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6 Ted Chen
2025-02-05 12:12 ` Nikolay Aleksandrov
2025-02-05 12:40 ` Ted Chen
2025-02-05 12:48 ` Nikolay Aleksandrov
2025-02-05 17:48 ` Ido Schimmel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).