Re: [PATCH net-next v2 2/3] net: dsa: allow use of phylink managed EEE support

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Fri, Feb 07, 2025 at 05:19:59PM +0200, Vladimir Oltean wrote:
> On Fri, Feb 07, 2025 at 01:09:38PM +0000, Russell King (Oracle) wrote:
> > In order to allow DSA drivers to use phylink managed EEE, changes are
> > necessary to the DSA .set_eee() and .get_eee() methods. Where drivers
> > make use of phylink managed EEE, these should just pass the method on
> > to their phylink implementation without calling the DSA specific
> > operations.
> > 
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > ---
> >  net/dsa/user.c | 21 +++++++++++++--------
> >  1 file changed, 13 insertions(+), 8 deletions(-)
> > 
> > diff --git a/net/dsa/user.c b/net/dsa/user.c
> > index 291ab1b4acc4..2e0a51c1b750 100644
> > --- a/net/dsa/user.c
> > +++ b/net/dsa/user.c
> > @@ -1243,16 +1243,21 @@ static int dsa_user_set_eee(struct net_device *dev, struct ethtool_keee *e)
> >  	if (!ds->ops->support_eee || !ds->ops->support_eee(ds, dp->index))
> >  		return -EOPNOTSUPP;
> >  
> > -	/* Port's PHY and MAC both need to be EEE capable */
> > -	if (!dev->phydev)
> > -		return -ENODEV;
> > +	/* If the port is using phylink managed EEE, then get_mac_eee is
> > +	 * unnecessary.
> 
> You thanked me for spotting that this should have been set_mac_eee() in
> the comment, but you didn't update it.
> https://lore.kernel.org/netdev/Z4bC77mwoeypDAdH@shell.armlinux.org.uk/

Bah - actually I _did_ update the patch, but in a different tree:

http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=net-queue&id=2ee2b1d5f0f8cee7dd748cfae9c20af429d5a4c2

I'm now looking at this wondering what updates were made in each tree
and therefore what I need to pass across between the two trees...

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!