Re: [PATCH net-next 3/7] eth: fbnic: support an additional RSS context

[Joe Damato <jdamato@fastly.com>]

On Thu, Feb 06, 2025 at 03:53:30PM -0800, Jakub Kicinski wrote:
> From: Daniel Zahka <daniel.zahka@gmail.com>
> 
> Add support for an extra RSS context. The device has a primary
> and a secondary context.
> 
> Signed-off-by: Daniel Zahka <daniel.zahka@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  .../net/ethernet/meta/fbnic/fbnic_ethtool.c   | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c b/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
> index 20cd9f5f89e2..4d73b405c8b9 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c
> @@ -374,6 +374,61 @@ fbnic_set_rxfh(struct net_device *netdev, struct ethtool_rxfh_param *rxfh,
>  	return 0;
>  }
>  
> +static int
> +fbnic_modify_rxfh_context(struct net_device *netdev,
> +			  struct ethtool_rxfh_context *ctx,
> +			  const struct ethtool_rxfh_param *rxfh,
> +			  struct netlink_ext_ack *extack)
> +{
> +	struct fbnic_net *fbn = netdev_priv(netdev);
> +	const u32 *indir = rxfh->indir;
> +	unsigned int changes;
> +
> +	if (!indir)
> +		indir = ethtool_rxfh_context_indir(ctx);

Was slightly confused by this, but I assume that there's an
indirection table in core and its possible that modify_rxfh_context
is called without a call to create... maybe in the case of the
default RSS context or something?

At any rate after browsing the fbnic code a bit: LGTM.

Reviewed-by: Joe Damato <jdamato@fastly.com>