From: Hangbin Liu <liuhangbin@gmail.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Simon Horman <horms@kernel.org>, Jianbo Liu <jianbol@nvidia.com>,
Boris Pismenny <borisp@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 net 0/2] bonding: fix incorrect mac address setting
Date: Sat, 8 Feb 2025 06:34:21 +0000 [thread overview]
Message-ID: <Z6b67YBbERi5v9gt@fedora> (raw)
In-Reply-To: <20250207092920.543458-1-liuhangbin@gmail.com>
Please hold on this patch. Our QE reported that with bare NIC, the
backup NIC can't receive the NS messages even after joining the multicast
MAC group. But after remove the backup NIC from bond, the NIC interface
could receive the NS message.
This is weird, it looks the backup NIC dropped the NS message somewhere,
even using tcpdump (the NIC will be in promisc mode) I can't capture the
NS message on backup slave.
I need to debug more.
Thanks
Hangbin
On Fri, Feb 07, 2025 at 09:29:18AM +0000, Hangbin Liu wrote:
> The mac address on backup slave should be convert from Solicited-Node
> Multicast address, not from bonding unicast target address.
>
> v3: also fix the mac setting for slave_set_ns_maddr. (Jay)
> Add function description for slave_set_ns_maddr/slave_set_ns_maddrs (Jay)
> v2: fix patch 01's subject
>
> Hangbin Liu (2):
> bonding: fix incorrect MAC address setting to receive NS messages
> selftests: bonding: fix incorrect mac address
>
> drivers/net/bonding/bond_options.c | 55 ++++++++++++++++---
> .../drivers/net/bonding/bond_options.sh | 4 +-
> 2 files changed, 49 insertions(+), 10 deletions(-)
>
> --
> 2.46.0
>
next prev parent reply other threads:[~2025-02-08 6:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 9:29 [PATCHv3 net 0/2] bonding: fix incorrect mac address setting Hangbin Liu
2025-02-07 9:29 ` [PATCHv3 net 1/2] bonding: fix incorrect MAC address setting to receive NS messages Hangbin Liu
2025-02-07 9:29 ` [PATCHv3 net 2/2] selftests: bonding: fix incorrect mac address Hangbin Liu
2025-02-08 6:34 ` Hangbin Liu [this message]
2025-02-11 7:31 ` [PATCHv3 net 0/2] bonding: fix incorrect mac address setting Hangbin Liu
2025-02-14 1:22 ` Hangbin Liu
2025-02-14 5:11 ` Jay Vosburgh
2025-02-16 15:11 ` Nikolay Aleksandrov
2025-03-05 8:25 ` Hangbin Liu
2025-03-06 2:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6b67YBbERi5v9gt@fedora \
--to=liuhangbin@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jianbol@nvidia.com \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).