netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sabrina Dubroca <sd@queasysnail.net>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>,
	Simon Horman <horms@kernel.org>,
	eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 3/4] tcp: use EXPORT_IPV6_MOD[_GPL]()
Date: Mon, 10 Feb 2025 10:30:44 +0100	[thread overview]
Message-ID: <Z6nHRDtxEG393A38@hog> (raw)
In-Reply-To: <20250210082805.465241-4-edumazet@google.com>

2025-02-10, 08:28:04 +0000, Eric Dumazet wrote:
> @@ -613,7 +613,7 @@ __poll_t tcp_poll(struct file *file, struct socket *sock, poll_table *wait)
>  
>  	return mask;
>  }
> -EXPORT_SYMBOL(tcp_poll);
> +EXPORT_IPV6_MOD(tcp_poll);

ktls uses it directly (net/tls/tls_main.c):

static __poll_t tls_sk_poll(struct file *file, struct socket *sock,
			    struct poll_table_struct *wait)
{
	struct tls_sw_context_rx *ctx;
	struct tls_context *tls_ctx;
	struct sock *sk = sock->sk;
	struct sk_psock *psock;
	__poll_t mask = 0;
	u8 shutdown;
	int state;

	mask = tcp_poll(file, sock, wait);
[...]
}

If you want to un-export tcp_poll, I guess we'll need to add the same
thing as for ->sk_data_ready (save the old ->poll to tls_context).

-- 
Sabrina

  parent reply	other threads:[~2025-02-10  9:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10  8:28 [PATCH net-next 0/4] net: add EXPORT_IPV6_MOD() Eric Dumazet
2025-02-10  8:28 ` [PATCH net-next 1/4] net: introduce EXPORT_IPV6_MOD() and EXPORT_IPV6_MOD_GPL() Eric Dumazet
2025-02-10  8:28 ` [PATCH net-next 2/4] inetpeer: use EXPORT_IPV6_MOD[_GPL]() Eric Dumazet
2025-02-10  8:28 ` [PATCH net-next 3/4] tcp: " Eric Dumazet
2025-02-10  8:41   ` Mateusz Polchlopek
2025-02-10  9:08     ` Eric Dumazet
2025-02-10  9:23       ` Mateusz Polchlopek
2025-02-10  9:30   ` Sabrina Dubroca [this message]
2025-02-10  9:44     ` Eric Dumazet
2025-02-10  9:56       ` Eric Dumazet
2025-02-10 11:35         ` Sabrina Dubroca
2025-02-10 12:26           ` Eric Dumazet
2025-02-10 12:21   ` kernel test robot
2025-02-10  8:28 ` [PATCH net-next 4/4] udp: " Eric Dumazet
2025-02-11  2:56   ` Willem de Bruijn
2025-02-11  8:08     ` Eric Dumazet
2025-02-10  9:25 ` [PATCH net-next 0/4] net: add EXPORT_IPV6_MOD() Mateusz Polchlopek
2025-02-10 18:33 ` Willem de Bruijn
2025-02-10 18:46   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6nHRDtxEG393A38@hog \
    --to=sd@queasysnail.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).