From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a3-smtp.messagingengine.com (fout-a3-smtp.messagingengine.com [103.168.172.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1232A1E376E for ; Mon, 10 Feb 2025 11:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.146 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187324; cv=none; b=G3tG8iCumgHIicaHcTPU/ts47iaxCmze75IeJpfuL6XkB+IOC2KVVW2a5CmmcW92uGJ8MSrmJAHA7N0J23DbNAXAzif+BVnS/ECeydVz7Qq8FkiXwLMmpTH0dh2RlVSUETwDJcJdv3/rr0YS17z/va9kU5Mkhur88AsVTiL9dU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739187324; c=relaxed/simple; bh=ET8c21wsugS8RJLoqvNZMgr824GQP5hkRBI+xZ+9KYA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nvzt3/gvHmFoGL4ldbWnOIX45zYOn7sGlFp6fbKq90EkOJBme4HaX7Roy1GjHiBAiXW7SJTWvq5Ylsk8aY6ReflIv8WWh5T5vROLXhmRMscK8HI7quGFpYr4O3glSsBJu0MDM58qpcXkBa8kpTWrtrTNPZU7+nIdSzUmwV6+Hlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=hlDxjjqY; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Ws/48LSs; arc=none smtp.client-ip=103.168.172.146 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="hlDxjjqY"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Ws/48LSs" Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id E40D01380860; Mon, 10 Feb 2025 06:35:19 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Mon, 10 Feb 2025 06:35:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1739187319; x=1739273719; bh=USLWubmwh3hB8L521uEOyNL1paWzsnZt qsP+3BkSb58=; b=hlDxjjqYhyznnVxd/AfXrwMMHeVTecOcwVNNZ/3rq75CAPnL NPt2aFEouC/mvzP5HTWRVTJTLpvx3l4R44KtMuzHbpFxfhLZ4gPSSzAnF9CKNQIh WahtyS/chcnPanaknILYBQAD7KOlK86gqwVwz6Wi7+0C16K/j3D/UwLUxSRBzNhr GErW9uHrfLu/F8/Aa0KUVrUtk18u0tGx4QrKMmjeoRZblSyhZvxi0JUdeGsvctEH 629W1TbKNOClrFrJ+tzuY3Iz27uePwYYKszjvwVK2/r9ojCZ9V6ZImVOXJgzjrbV 1vpM4JVMIPHgkF9GanFB1emrZRyweXLXXOxlXQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1739187319; x= 1739273719; bh=USLWubmwh3hB8L521uEOyNL1paWzsnZtqsP+3BkSb58=; b=W s/48LSspDCpDlllhpTsgNgao5K3HpcO2aDp8qHWanGv02rgcgv0CW4qzMlyPfgOG Ka6w+rm6/raaEjuWPsqkcBVcYcMn3lDOTReFVRE+4dPz5aTKQ15rM0uXUpQJuuqt rn0GNJH25I8dV7b2+NU6gPWpzU02Sbt3bh/LMIWdJ2Vt8t36dkXlkiqAUcFMOmtN jXt2MlBxi9Vd6NCv3At7buvu/p/yqzOj1k1vFxAtYOFX73LZ/yT/MTq7xT1dYc0p T9rCjdapzwqse4dWARZkejaVXgAoHH6wMDMtJErJGOqMX3JnRJY6Y9ve0jB4GklZ qxy/bbo1rCrKISWxc3ISw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefjeelhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddt jeenucfhrhhomhepufgrsghrihhnrgcuffhusghrohgtrgcuoehsugesqhhuvggrshihsh hnrghilhdrnhgvtheqnecuggftrfgrthhtvghrnhepgfdvgeeitefffedvgfdutdelgeei hfegueehteevveegveejudelfeffieehledvnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhn sggprhgtphhtthhopeekpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvughumh griigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhl ohhfthdrnhgvthdprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpth htohepphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehnvghtuggvvhes vhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopeifihhllhgvmhgssehgohhogh hlvgdrtghomhdprhgtphhtthhopehhohhrmhhssehkvghrnhgvlhdrohhrghdprhgtphht thhopegvrhhitgdrughumhgriigvthesghhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Feb 2025 06:35:19 -0500 (EST) Date: Mon, 10 Feb 2025 12:35:17 +0100 From: Sabrina Dubroca To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Willem de Bruijn , Simon Horman , eric.dumazet@gmail.com Subject: Re: [PATCH net-next 3/4] tcp: use EXPORT_IPV6_MOD[_GPL]() Message-ID: References: <20250210082805.465241-1-edumazet@google.com> <20250210082805.465241-4-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: 2025-02-10, 10:56:22 +0100, Eric Dumazet wrote: > On Mon, Feb 10, 2025 at 10:44 AM Eric Dumazet wrote: > > > > On Mon, Feb 10, 2025 at 10:30 AM Sabrina Dubroca wrote: > > > > > > 2025-02-10, 08:28:04 +0000, Eric Dumazet wrote: > > > > @@ -613,7 +613,7 @@ __poll_t tcp_poll(struct file *file, struct socket *sock, poll_table *wait) > > > > > > > > return mask; > > > > } > > > > -EXPORT_SYMBOL(tcp_poll); > > > > +EXPORT_IPV6_MOD(tcp_poll); > > > > > > ktls uses it directly (net/tls/tls_main.c): > > > > > > Oh, right. > > > > > > > > static __poll_t tls_sk_poll(struct file *file, struct socket *sock, > > > struct poll_table_struct *wait) > > > { > > > struct tls_sw_context_rx *ctx; > > > struct tls_context *tls_ctx; > > > struct sock *sk = sock->sk; > > > struct sk_psock *psock; > > > __poll_t mask = 0; > > > u8 shutdown; > > > int state; > > > > > > mask = tcp_poll(file, sock, wait); > > > [...] > > > } > > > > > > If you want to un-export tcp_poll, I guess we'll need to add the same > > > thing as for ->sk_data_ready (save the old ->poll to tls_context). > > > > No need, I simply missed tls was using tcp_poll() can could be a > > module, I will fix in V2 > > > > TLS also calls tcp_under_memory_pressure() via tcp_epollin_ready(), > so tcp_memory_pressure needs to be exported as well. Ah, yes, didn't think about inline helpers. I ran a quick build since I was concerned about what the Chelsio TOE driver might be using, but spotted this instead: ERROR: modpost: "secure_tcpv6_seq" [drivers/infiniband/hw/irdma/irdma.ko] undefined! -- Sabrina