From: Jiri Olsa <olsajiri@gmail.com>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Yan Zhai <yan@cloudflare.com>
Subject: Re: [PATCH v2 bpf] net: Add rx_skb of kfree_skb to raw_tp_null_args[].
Date: Mon, 10 Feb 2025 18:49:12 +0100 [thread overview]
Message-ID: <Z6o8GKce9xSDlAC2@krava> (raw)
In-Reply-To: <Z59Donij6yuw9hvB@krava>
On Sun, Feb 02, 2025 at 11:06:26AM +0100, Jiri Olsa wrote:
> On Sat, Feb 01, 2025 at 09:15:28AM +0100, Alexei Starovoitov wrote:
> > On Sat, Feb 1, 2025 at 9:13 AM Jiri Olsa <olsajiri@gmail.com> wrote:
> > >
> > > > v2:
> > > > * Add kfree_skb to raw_tp_null_args[] instead of annotating
> > > > rx_skb with __nullable
> > >
> > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> >
> > Jiri, Kumar,
> > how come that we missed it earlier?
> > Is this a new change in the tracepoint?
>
> must have slipped, sry.. I'll double check tracepoints again
sry for late reply, I was traveling last week
I overlooked tracepoints defined in drivers directly :-\
however there was one recent change adding the null check:
9ab96b524dce hugetlb: fix NULL pointer dereference in trace_hugetlbfs_alloc_inode
will send update shortly
jirka
next prev parent reply other threads:[~2025-02-10 17:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 3:01 [PATCH v2 bpf] net: Add rx_skb of kfree_skb to raw_tp_null_args[] Kuniyuki Iwashima
2025-02-01 3:16 ` Yan Zhai
2025-02-01 8:13 ` Jiri Olsa
2025-02-01 8:15 ` Alexei Starovoitov
2025-02-02 10:06 ` Jiri Olsa
2025-02-10 17:49 ` Jiri Olsa [this message]
2025-02-03 13:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6o8GKce9xSDlAC2@krava \
--to=olsajiri@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yan@cloudflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).