From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC94B1BD9D2; Tue, 11 Feb 2025 09:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739266762; cv=none; b=p3YSNqtaLLxSY5kE6ZSCJxV7HNN4LhvJeRdb2FgOm9rpr/PwG1MLaQVFeYBN6LBl/H6bqP0iJ4FDqjYRilPNfTdMygI9qrfPdUOoej51gQ/d0UYBq12wHo0TaIbtiaUQyvhPyUT6lCtSbKWtv+tDyMi/lzdtoQoFJQ6cvbqYLv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739266762; c=relaxed/simple; bh=FDMciW6TLpEAMbkjQIVGCNbvKy5Ug5oPSQE/94sMcPM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p4Xcwmg0Y3b3C2eXnhuM1COgM0BRQodHZkgT5hU9MJxPMD9uht6vkSkA2gfTwOnZ9UgTz33HzRuk6C7d4qpm10yegoaZAl7/FITnCCbcE7+/qxdu4vNaVM3GURzzU4vkR3lwQFcRaq1OnSGBg7D1kSCnrS8OvVdIp12lprad09U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: 8YpW5iXTSEGIQ/5t0VYFRQ== X-CSE-MsgGUID: Q0G+jQrCRISzqKzSRNH6Pg== X-IronPort-AV: E=McAfee;i="6700,10204,11341"; a="50512301" X-IronPort-AV: E=Sophos;i="6.13,277,1732608000"; d="scan'208";a="50512301" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 01:39:20 -0800 X-CSE-ConnectionGUID: cJvLFL1FQAm1X4Xl9szJ9g== X-CSE-MsgGUID: WtVy6JKQSCiOBQl3Jo+Lvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="112318016" Received: from smile.fi.intel.com ([10.237.72.58]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 01:39:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1thmjV-0000000ASXJ-1H97; Tue, 11 Feb 2025 11:39:09 +0200 Date: Tue, 11 Feb 2025 11:39:09 +0200 From: Andy Shevchenko To: David Lechner Cc: Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v3 01/15] gpiolib: add gpiod_multi_set_value_cansleep() Message-ID: References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> <20250210-gpio-set-array-helper-v3-1-d6a673674da8@baylibre.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250210-gpio-set-array-helper-v3-1-d6a673674da8@baylibre.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Feb 10, 2025 at 04:33:27PM -0600, David Lechner wrote: > Add a new gpiod_multi_set_value_cansleep() helper function with fewer > parameters than gpiod_set_array_value_cansleep(). > > Calling gpiod_set_array_value_cansleep() can get quite verbose. In many > cases, the first arguments all come from the same struct gpio_descs, so > having a separate function where we can just pass that cuts down on the > boilerplate. LGTM now, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko