From: Saeed Mahameed <saeed@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Tariq Toukan <tariqt@nvidia.com>,
Edward Cree <ecree.xilinx@gmail.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] Symmetric OR-XOR RSS hash
Date: Wed, 12 Feb 2025 10:13:58 -0800 [thread overview]
Message-ID: <Z6zk5qMCP1juVN6o@x130> (raw)
In-Reply-To: <68e2a8cc-2371-433b-86a3-ac9dea48fb43@nvidia.com>
On 11 Feb 17:26, Gal Pressman wrote:
>On 11/02/2025 2:27, Jakub Kicinski wrote:
>> On Sun, 9 Feb 2025 09:59:22 +0200 Gal Pressman wrote:
>>> I don't understand the rationale, the new input_xfrm field didn't
>>> deserve a selftest, why does a new value to the field does?
>>
>> Ahmed and Sudheer added ETHTOOL_MSG_RSS_GET as part of their work.
>> Everyone pays off a little bit of technical debt to get their
>> feature in.
>
>I agree with the idea that extensions to ethtool uapi should be
>accompanied by conversion to netlink.
>
>I don't see a connection to testing. If a maintainer has certain
>expectations about which changes require tests, it should be documented
>and enforced so it's not up to the maintainer's mood. FWIW, I don't
>believe kernel contributions should be blocked by lack of a test.
>
>>
>> I don't appreciate your reaction. Please stop acting as if nVidia was
>> a victim of some grand conspiracy within netdev.
The main problem is the tone in theses responses, we appreciate your
reviews and comments, but sometimes the responses and comments are a
bit too hostile.
>
>I don't know what you're talking about, you've mistaken me for someone
>else..
>
Misunderstanding ? ..
Gal's response was technical, objective and free from any "I'm a victim"
complaints, so I get why he's confused.
I understand that there's some friction going on with a few nVidia WIP
features, but there's no reasons for comments and reactions to not remain
in the technical realm.
Anyway I am happy to discuss all open issues and misunderstandings offline.
All we need is to just align expectations and work towards a shared plan
and a maintainer vs contributor friendly policy.
LKM.
prev parent reply other threads:[~2025-02-12 18:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 13:53 [PATCH net-next v2 0/2] Symmetric OR-XOR RSS hash Gal Pressman
2025-02-05 13:53 ` [PATCH net-next v2 1/2] ethtool: " Gal Pressman
2025-02-05 22:20 ` Edward Cree
2025-02-07 1:31 ` Jakub Kicinski
2025-02-09 7:59 ` Gal Pressman
2025-02-05 13:53 ` [PATCH net-next v2 2/2] net/mlx5e: Symmetric OR-XOR RSS hash control Gal Pressman
2025-02-07 1:32 ` [PATCH net-next v2 0/2] Symmetric OR-XOR RSS hash Jakub Kicinski
2025-02-09 7:59 ` Gal Pressman
2025-02-11 0:27 ` Jakub Kicinski
2025-02-11 15:26 ` Gal Pressman
2025-02-12 18:13 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6zk5qMCP1juVN6o@x130 \
--to=saeed@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox