netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Edward Cree <ecree.xilinx@gmail.com>,
	Martin Habets <habetsm.xilinx@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>, Simon Horman <horms@kernel.org>,
	Julia Lawall <Julia.Lawall@inria.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [PATCH net-next 0/5] Add missing netlink error message macros to coccinelle test
Date: Thu, 27 Feb 2025 06:41:39 +0100	[thread overview]
Message-ID: <Z7/7E0kfDHvK1hXd@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250226093904.6632-1-gal@nvidia.com>

On Wed, Feb 26, 2025 at 11:38:59AM +0200, Gal Pressman wrote:
> The newline_in_nl_msg.cocci test is missing some variants in the list of
> checked macros, add them and fix all reported issues.
> 
> Thanks,
> Gal
> 
> Gal Pressman (5):
>   coccinelle: Add missing (GE)NL_SET_ERR_MSG_* to strings ending with
>     newline test
>   net/mlx5: Remove newline at the end of a netlink error message
>   sfc: Remove newline at the end of a netlink error message
>   net: sched: Remove newline at the end of a netlink error message
>   ice: dpll: Remove newline at the end of a netlink error message
> 
>  drivers/net/ethernet/intel/ice/ice_dpll.c          | 14 +++++++-------
>  drivers/net/ethernet/mellanox/mlx5/core/dpll.c     |  2 +-
>  .../ethernet/mellanox/mlx5/core/en/tc_tun_vxlan.c  |  2 +-
>  .../net/ethernet/mellanox/mlx5/core/en_ethtool.c   |  2 +-
>  .../net/ethernet/mellanox/mlx5/core/esw/bridge.c   |  6 +++---
>  drivers/net/ethernet/sfc/mae.c                     |  2 +-
>  drivers/net/ethernet/sfc/tc.c                      |  6 +++---
>  net/sched/sch_qfq.c                                |  2 +-
>  scripts/coccinelle/misc/newline_in_nl_msg.cocci    | 13 ++++++++-----
>  9 files changed, 26 insertions(+), 23 deletions(-)
> 

I looked at the whole series, thanks:
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>

> -- 
> 2.40.1

  parent reply	other threads:[~2025-02-27  5:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26  9:38 [PATCH net-next 0/5] Add missing netlink error message macros to coccinelle test Gal Pressman
2025-02-26  9:39 ` [PATCH net-next 1/5] coccinelle: Add missing (GE)NL_SET_ERR_MSG_* to strings ending with newline test Gal Pressman
2025-02-26  9:39 ` [PATCH net-next 2/5] net/mlx5: Remove newline at the end of a netlink error message Gal Pressman
2025-02-26  9:39 ` [PATCH net-next 3/5] sfc: " Gal Pressman
2025-02-26  9:39 ` [PATCH net-next 4/5] net: sched: " Gal Pressman
2025-02-26  9:39 ` [PATCH net-next 5/5] ice: dpll: " Gal Pressman
2025-02-26 13:48   ` Przemek Kitszel
2025-02-27  5:41 ` Michal Swiatkowski [this message]
2025-02-28  2:20 ` [PATCH net-next 0/5] Add missing netlink error message macros to coccinelle test patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7/7E0kfDHvK1hXd@mev-dev.igk.intel.com \
    --to=michal.swiatkowski@linux.intel.com \
    --cc=Julia.Lawall@inria.fr \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.palix@imag.fr \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=tariqt@nvidia.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).