From: Joe Damato <jdamato@fastly.com>
To: John Daley <johndale@cisco.com>
Cc: benve@cisco.com, satishkh@cisco.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Nelson Escobar <neescoba@cisco.com>
Subject: Re: [PATCH net-next 1/1] enic: add dependency on Page Pool
Date: Mon, 24 Feb 2025 22:17:32 -0500 [thread overview]
Message-ID: <Z702TLsTKDIvTQN_@LQ3V64L9R2> (raw)
In-Reply-To: <20250224234350.23157-2-johndale@cisco.com>
On Mon, Feb 24, 2025 at 03:43:50PM -0800, John Daley wrote:
> Driver was not configured to select page_pool, causing a compile error
> if page pool module was not already selected.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502211253.3XRosM9I-lkp@intel.com/
> Fixes: d24cb52b2d8a ("enic: Use the Page Pool API for RX")
> Reviewed-by: Nelson Escobar <neescoba@cisco.com>
> Signed-off-by: John Daley <johndale@cisco.com>
> ---
> drivers/net/ethernet/cisco/enic/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Hrm. This is a fixes, so normally the subject line should probably
be "PATCH net" instead of "PATCH net-next" and stable would be CC'd
- however - it looks like the commit it fixes is only in net-next.
So, CC-ing stable is probably unnecessary ?
At any rate, I'd probably skip the cover letter for a simple patch
like this in the future.
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-02-25 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 23:43 [PATCH net-next 0/1] enic: add dependency on Page Pool John Daley
2025-02-24 23:43 ` [PATCH net-next 1/1] " John Daley
2025-02-25 3:17 ` Joe Damato [this message]
2025-02-26 3:20 ` [PATCH net-next 0/1] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z702TLsTKDIvTQN_@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=andrew+netdev@lunn.ch \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johndale@cisco.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox