[PATCH net-next 0/1] enic: add dependency on Page Pool

[PATCH net-next 0/1] enic: add dependency on Page Pool

[John Daley]

Driver was not configured to select page_pool, causing a compile error
if page pool module was not already selected.

Signed-off-by: John Daley <johndale@cisco.com>

John Daley (1):
  enic: Add dependency on Page Pool

 drivers/net/ethernet/cisco/enic/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.39.3

[PATCH net-next 1/1] enic: add dependency on Page Pool

[John Daley]

Driver was not configured to select page_pool, causing a compile error
if page pool module was not already selected.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502211253.3XRosM9I-lkp@intel.com/
Fixes: d24cb52b2d8a ("enic: Use the Page Pool API for RX")
Reviewed-by: Nelson Escobar <neescoba@cisco.com>
Signed-off-by: John Daley <johndale@cisco.com>
---
 drivers/net/ethernet/cisco/enic/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cisco/enic/Kconfig b/drivers/net/ethernet/cisco/enic/Kconfig
index ad80c0fa96a6..96709875fe4f 100644
--- a/drivers/net/ethernet/cisco/enic/Kconfig
+++ b/drivers/net/ethernet/cisco/enic/Kconfig
@@ -6,5 +6,6 @@
 config ENIC
 	tristate "Cisco VIC Ethernet NIC Support"
 	depends on PCI
+	select PAGE_POOL
 	help
 	  This enables the support for the Cisco VIC Ethernet card.
-- 
2.39.3

Re: [PATCH net-next 1/1] enic: add dependency on Page Pool

[Joe Damato]

On Mon, Feb 24, 2025 at 03:43:50PM -0800, John Daley wrote:
> Driver was not configured to select page_pool, causing a compile error
> if page pool module was not already selected.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502211253.3XRosM9I-lkp@intel.com/
> Fixes: d24cb52b2d8a ("enic: Use the Page Pool API for RX")
> Reviewed-by: Nelson Escobar <neescoba@cisco.com>
> Signed-off-by: John Daley <johndale@cisco.com>
> ---
>  drivers/net/ethernet/cisco/enic/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Hrm. This is a fixes, so normally the subject line should probably
be "PATCH net" instead of "PATCH net-next" and stable would be CC'd
- however - it looks like the commit it fixes is only in net-next.

So, CC-ing stable is probably unnecessary ?

At any rate, I'd probably skip the cover letter for a simple patch
like this in the future.

Reviewed-by: Joe Damato <jdamato@fastly.com>

Re: [PATCH net-next 0/1] enic: add dependency on Page Pool

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 24 Feb 2025 15:43:49 -0800 you wrote:
> Driver was not configured to select page_pool, causing a compile error
> if page pool module was not already selected.
> 
> Signed-off-by: John Daley <johndale@cisco.com>
> 
> John Daley (1):
>   enic: Add dependency on Page Pool
> 
> [...]

Here is the summary with links:
  - [net-next,1/1] enic: add dependency on Page Pool
    https://git.kernel.org/netdev/net-next/c/91c8d8e4b7a3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html