From: Ido Schimmel <idosch@idosch.org>
To: Anna Emese Nyiri <annaemesenyiri@gmail.com>
Cc: netdev@vger.kernel.org, fejes@inf.elte.hu, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, willemb@google.com,
horms@kernel.org, davem@davemloft.net, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3] selftests: net: add support for testing SO_RCVMARK and SO_RCVPRIORITY
Date: Sun, 16 Feb 2025 19:32:46 +0200 [thread overview]
Message-ID: <Z7IhPhvwXlXzXysv@shredder> (raw)
In-Reply-To: <20250214205828.48503-1-annaemesenyiri@gmail.com>
On Fri, Feb 14, 2025 at 09:58:28PM +0100, Anna Emese Nyiri wrote:
> Introduce tests to verify the correct functionality of the SO_RCVMARK and
> SO_RCVPRIORITY socket options.
>
> Key changes include:
>
> - so_rcv_listener.c: Implements a receiver application to test the correct
> behavior of the SO_RCVMARK and SO_RCVPRIORITY options.
> - test_so_rcv.sh: Provides a shell script to automate testing for these options.
> - Makefile: Integrates test_so_rcv.sh into the kernel selftests.
>
> v3:
I put the changelog under the "---" so that it won't be recorded in the
commit message. Nowadays maintainers usually record a lore link in the
commit message, so it's easy to reach the changelog from git log.
Example:
https://lore.kernel.org/netdev/056c8f4765a52179630b904e95fc4e3f26c02f2a.1739548836.git.petrm@nvidia.com/
You can use git-notes for that:
https://git-scm.com/docs/git-notes
>
> - Add the C part to TEST_GEN_FILES.
> - Ensure the test fails if no cmsg of type opt.name is received
> in so_rcv_listener.c
> - Rebased on net-next.
>
> v2:
>
> https://lore.kernel.org/netdev/20250210192216.37756-1-annaemesenyiri@gmail.com/
> - Add the C part to TEST_GEN_PROGS and .gitignore.
> - Modify buffer space and add IPv6 testing option
> in so_rcv_listener.c.
> - Add IPv6 testing, remove unnecessary comment,
> add kselftest exit codes, run both binaries in a namespace,
> and add sleep in test_so_rcv.sh.
> The sleep was added to ensure that the listener process has
> enough time to start before the sender attempts to connect.
> - Rebased on net-next.
>
> v1:
>
> https://lore.kernel.org/netdev/20250129143601.16035-2-annaemesenyiri@gmail.com/
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Suggested-by: Ferenc Fejes <fejes@inf.elte.hu>
> Signed-off-by: Anna Emese Nyiri <annaemesenyiri@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2025-02-16 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 20:58 [PATCH net-next v3] selftests: net: add support for testing SO_RCVMARK and SO_RCVPRIORITY Anna Emese Nyiri
2025-02-15 15:21 ` Willem de Bruijn
2025-02-16 17:32 ` Ido Schimmel [this message]
2025-02-18 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7IhPhvwXlXzXysv@shredder \
--to=idosch@idosch.org \
--cc=annaemesenyiri@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fejes@inf.elte.hu \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox